From af0d05d7b1897dad87bd4e7d8a86d607b4cf05bd Mon Sep 17 00:00:00 2001 From: Tetsui Ohkubo Date: Thu, 25 Oct 2018 02:59:42 +0000 Subject: [PATCH] NewMessageListView: Remove the flag. This is the 2nd part of 3 CLs removing old MessageListView code. The split is suggested in the review. https://crrev.com/c/1292667 (1) Removing the old implementation (2) Removing the flag (3) Renaming the implementation TEST=trybot pass BUG=870801 Change-Id: Id9b08072e9d9a35ca785552056b5056e0dc608e4 Reviewed-on: https://chromium-review.googlesource.com/c/1297769 Commit-Queue: Tetsui Ohkubo Reviewed-by: Yoshiki Iguchi Reviewed-by: James Cook Cr-Commit-Position: refs/heads/master@{#602593} --- ash/public/cpp/ash_features.cc | 7 ------- ash/public/cpp/ash_features.h | 5 ----- chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag_descriptions.cc | 7 ------- chrome/browser/flag_descriptions.h | 6 ------ 5 files changed, 29 deletions(-) diff --git a/ash/public/cpp/ash_features.cc b/ash/public/cpp/ash_features.cc index 5e0a52dca05949..6d4a7b7e16bc6a 100644 --- a/ash/public/cpp/ash_features.cc +++ b/ash/public/cpp/ash_features.cc @@ -35,9 +35,6 @@ const base::Feature kLockScreenHideSensitiveNotificationsSupport{ "LockScreenHideSensitiveNotificationsSupport", base::FEATURE_DISABLED_BY_DEFAULT}; -const base::Feature kNewMessageListView{"NewMessageListView", - base::FEATURE_ENABLED_BY_DEFAULT}; - const base::Feature kMediaSessionAccelerators{ "MediaSessionAccelerators", base::FEATURE_DISABLED_BY_DEFAULT}; @@ -85,10 +82,6 @@ bool IsLockScreenHideSensitiveNotificationsSupported() { kLockScreenHideSensitiveNotificationsSupport); } -bool IsNewMessageListViewEnabled() { - return base::FeatureList::IsEnabled(kNewMessageListView); -} - bool IsNightLightEnabled() { return base::FeatureList::IsEnabled(kNightLight); } diff --git a/ash/public/cpp/ash_features.h b/ash/public/cpp/ash_features.h index fda3ac4a36e0a7..4534c54afdad29 100644 --- a/ash/public/cpp/ash_features.h +++ b/ash/public/cpp/ash_features.h @@ -54,9 +54,6 @@ ASH_PUBLIC_EXPORT extern const base::Feature // TODO(beccahughes): Remove after launch. (https://crbug.com/894255) ASH_PUBLIC_EXPORT extern const base::Feature kMediaSessionAccelerators; -// Enables new message list view. https://crbug.com/769219 -ASH_PUBLIC_EXPORT extern const base::Feature kNewMessageListView; - // Enables the Night Light feature. ASH_PUBLIC_EXPORT extern const base::Feature kNightLight; @@ -92,8 +89,6 @@ ASH_PUBLIC_EXPORT bool IsLockScreenInlineReplyEnabled(); ASH_PUBLIC_EXPORT bool IsLockScreenHideSensitiveNotificationsSupported(); -ASH_PUBLIC_EXPORT bool IsNewMessageListViewEnabled(); - ASH_PUBLIC_EXPORT bool IsNightLightEnabled(); ASH_PUBLIC_EXPORT bool IsNotificationScrollBarEnabled(); diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index c60e4533d7cf29..afe4fbd477d014 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -1692,10 +1692,6 @@ const FeatureEntry kFeatureEntries[] = { flag_descriptions::kEnableNotificationScrollBarName, flag_descriptions::kEnableNotificationScrollBarDescription, kOsCrOS, FEATURE_VALUE_TYPE(ash::features::kNotificationScrollBar)}, - {"ash-enable-new-message-list-view", - flag_descriptions::kEnableNewMessageListViewName, - flag_descriptions::kEnableNewMessageListViewDescription, kOsCrOS, - FEATURE_VALUE_TYPE(ash::features::kNewMessageListView)}, {"allow-touchpad-three-finger-click", flag_descriptions::kAllowTouchpadThreeFingerClickName, flag_descriptions::kAllowTouchpadThreeFingerClickDescription, kOsCrOS, diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index 45a6139cba06da..9256c30661611b 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc @@ -670,10 +670,6 @@ const char kEnableNotificationScrollBarName[] = const char kEnableNotificationScrollBarDescription[] = "Enable the scroll bar of the notification list in Unified System Tray."; -const char kEnableNewMessageListViewName[] = "Enable new message list view"; -const char kEnableNewMessageListViewDescription[] = - "Enable new implementation of message list view."; - const char kEnableNupPrintingName[] = "Enable N-up printing"; const char kEnableNupPrintingDescription[] = "Enable N-up printing in the print preview panel."; @@ -1638,9 +1634,6 @@ const char kShelfHoverPreviewsDescription[] = "Shows previews of the open windows for a given running app when hovering " "over the shelf."; -const char kShelfNewUiName[] = "Newest shelf redesign."; -const char kShelfNewUiDescription[] = "Enables the newest shelf appearance."; - const char kShowAndroidFilesInFilesAppName[] = "Show Android files in Files app"; const char kShowAndroidFilesInFilesAppDescription[] = diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index 6b2d6d718b0a15..910dbe90538d21 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h @@ -428,9 +428,6 @@ extern const char kEnableNightLightDescription[]; extern const char kEnableNotificationScrollBarName[]; extern const char kEnableNotificationScrollBarDescription[]; -extern const char kEnableNewMessageListViewName[]; -extern const char kEnableNewMessageListViewDescription[]; - extern const char kEnableNupPrintingName[]; extern const char kEnableNupPrintingDescription[]; @@ -993,9 +990,6 @@ extern const char kSettingsWindowDescription[]; extern const char kShelfHoverPreviewsName[]; extern const char kShelfHoverPreviewsDescription[]; -extern const char kShelfNewUiName[]; -extern const char kShelfNewUiDescription[]; - extern const char kShowAndroidFilesInFilesAppName[]; extern const char kShowAndroidFilesInFilesAppDescription[];