Skip to content

Commit

Permalink
WebUI: change up some owners
Browse files Browse the repository at this point in the history
1. Remove estade@ from main OWNERS file
   πŸ‘‹ So long and thanks for all the fish! 🐟🐠

2. Create a "PLATFORM_OWNERS" file so that fukino@ can be added
   for only ui/webui/ (and not all the other things covered).

3. Add calamity@ to new PLATFORM_OWNERS file.

4. Add groby@ to content/browser/webui/ for her super contributions.

5. Add dschuyler@ to ui/base/webui/ for his sweet $i18n{} stuff.

R=estade@chromium.org,fukino@chromium.org,calamity@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2812803002
Cr-Commit-Position: refs/heads/master@{#465902}
  • Loading branch information
danbeam authored and Commit bot committed Apr 20, 2017
1 parent 5b42152 commit af7339e
Show file tree
Hide file tree
Showing 12 changed files with 22 additions and 23 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ per-file BUILD.gn=*

per-file *_android.*=file://chrome/browser/android/OWNERS

per-file browser_resources.grd=file://ui/webui/OWNERS
per-file browser_resources.grd=file://ui/webui/PLATFORM_OWNERS
per-file browser_resources.grd=calamity@chromium.org
per-file browser_resources.grd=tsergeant@chromium.org

Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/resources/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

per-file component_extension_resources.grd=dgozman@chromium.org
per-file options_resources.grd=file://chrome/browser/resources/options/OWNERS
Expand Down
1 change: 0 additions & 1 deletion chrome/browser/resources/uber/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
dbeam@chromium.org
estade@chromium.org

# COMPONENT: UI>Browser>WebUI
2 changes: 1 addition & 1 deletion chrome/browser/ui/webui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

per-file devtools_ui*=dgozman@chromium.org
per-file devtools_ui*=pfeldman@chromium.org
Expand Down
2 changes: 1 addition & 1 deletion chrome/renderer/resources/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

per-file offline.js=edwardjung@chromium.org
2 changes: 1 addition & 1 deletion components/about_ui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

# COMPONENT: UI>Browser>WebUI
2 changes: 1 addition & 1 deletion components/flags_ui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

asvitkine@chromium.org

Expand Down
2 changes: 1 addition & 1 deletion components/version_ui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
file://ui/webui/OWNERS
file://ui/webui/PLATFORM_OWNERS

# COMPONENT: UI>Browser>WebUI
4 changes: 1 addition & 3 deletions content/browser/webui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
dbeam@chromium.org
groby@chromium.org
tommycli@chromium.org

# Emeritus
estade@chromium.org

# COMPONENT: UI>Browser>WebUI
5 changes: 3 additions & 2 deletions ui/base/webui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
dbeam@chromium.org
estade@chromium.org
file://ui/webui/PLATFORM_OWNERS

dschuyler@chromium.org

# COMPONENT: UI>Browser>WebUI
12 changes: 2 additions & 10 deletions ui/webui/OWNERS
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
# Please use more specific OWNERS when possible.
bauerb@chromium.org
dbeam@chromium.org
dpapad@chromium.org
michaelpg@chromium.org
pam@chromium.org
tommycli@chromium.org
xiyuan@chromium.org
file://ui/webui/PLATFORM_OWNERS

# Emeritus
estade@chromium.org
fukino@chromium.org

# COMPONENT: UI>Browser>WebUI
9 changes: 9 additions & 0 deletions ui/webui/PLATFORM_OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Please use more specific OWNERS when possible.
bauerb@chromium.org
calamity@chromium.org
dbeam@chromium.org
dpapad@chromium.org
michaelpg@chromium.org
pam@chromium.org
tommycli@chromium.org
xiyuan@chromium.org

0 comments on commit af7339e

Please sign in to comment.