Add ToT Windows Coverage master and fix typo.

Bug: 1090653 Change-Id: Ie233b9d9c6433a5e62d3f83177319132c937107e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523356 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#824958}
Denger-Network · Nov 6, 2020 · b29bb27 · b29bb27
1 parent d46be1a
commit b29bb27
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/infra/config/generated/luci-milo.cfg b/infra/config/generated/luci-milo.cfg
@@ -3893,6 +3893,11 @@ consoles {
     category: "ToT Code Coverage"
     short_name: "mac"
   }
+  builders {
+    name: "buildbucket/luci.chromium.ci/ToTWindowsCoverage"
+    category: "ToT Code Coverage"
+    short_name: "win"
+  }
   builders {
     name: "buildbucket/luci.chromium.ci/CFI Linux CF"
     category: "CFI|Linux"
@@ -3913,11 +3918,6 @@ consoles {
     category: "CFI|Win"
     short_name: "x64"
   }
-  builders {
-    name: "buildbucket/luci.chromium.ci/ToTWindowsCoverage"
-    category: "Tot Code Coverage"
-    short_name: "win"
-  }
   builders {
     name: "buildbucket/luci.chromium.ci/ToTiOS"
     category: "iOS|public"

diff --git a/infra/config/subprojects/chromium/ci.star b/infra/config/subprojects/chromium/ci.star
@@ -1608,7 +1608,7 @@ ci.clang_builder(
 ci.clang_builder(
     name = "ToTWindowsCoverage",
     console_view_entry = ci.console_view_entry(
-        category = "Tot Code Coverage",
+        category = "ToT Code Coverage",
         short_name = "win",
     ),
     executable = "recipe:chromium_clang_coverage_tot",

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
@@ -188,6 +188,7 @@
       'ToTWinASanLibfuzzer': 'libfuzzer_windows_asan_clang_tot_release_bot',
       'ToTWinCFI': 'clang_tot_win_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on_x86',
       'ToTWinCFI64': 'clang_tot_win_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on',
+      'ToTWindowsCoverage': 'clang_tot_coverage_minimal_symbols_release',
       'ToTWinThinLTO64': 'clang_tot_win_official_full_symbols_thin_lto_static',
       'ToTiOS': 'ios_clang_tot_xctest',
       'ToTiOSDevice': 'ios_clang_device_tot_xctest',

diff --git a/tools/mb/mb_config_expectations/chromium.clang.json b/tools/mb/mb_config_expectations/chromium.clang.json
@@ -400,6 +400,15 @@
       "win_linker_timing": true
     }
   },
+  "ToTWindowsCoverage": {
+    "gn_args": {
+      "is_clang": true,
+      "is_debug": false,
+      "llvm_force_head_revision": true,
+      "symbol_level": 1,
+      "use_clang_coverage": true
+    }
+  },
   "ToTiOS": {
     "gn_args": {
       "enable_run_ios_unittests_with_xctest": true,