forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert of Enforce capability spec renderer <--> browser (patchset chr…
…omium#11 id:200001 of https://codereview.chromium.org/2259903002/ ) Reason for revert: This breaks cast linux bot: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux content_unittests/MergeDictionaryTest.Merge crashing: e.g. https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/31440/steps/content_unittests/logs/stdio Received signal 11 SEGV_MAPERR 000000000018 #0 0x000002aa5b67 base::debug::(anonymous namespace)::StackDumpSignalHandler() chromium#1 0x7fd343c82340 <unknown> chromium#2 0x000002b03806 base::ListValue::AppendString() chromium#3 0x0000022f9abf content::MergeDictionary() chromium#4 0x000000c912da content::MergeDictionaryTest_Merge_Test::TestBody() chromium#5 0x00000291c547 testing::Test::Run() chromium#6 0x00000291d203 testing::TestInfo::Run() chromium#7 0x00000291d697 testing::TestCase::Run() chromium#8 0x0000029246d7 testing::internal::UnitTestImpl::RunAllTests() chromium#9 0x00000292432a testing::UnitTest::Run() chromium#10 0x0000024e4ec3 base::TestSuite::Run() chromium#11 0x0000024f4809 base::(anonymous namespace)::LaunchUnitTestsInternal() chromium#12 0x0000024f46cb base::LaunchUnitTests() chromium#13 0x00000137df7f main chromium#14 0x7fd341479ec5 __libc_start_main chromium#15 0x00000053229d <unknown> r8: 0000000000000003 r9: 0000000000000001 r10: 0000000057d83dcb r11: 00007fd3415de870 r12: 00007fd341d363f8 r13: 00003fed7ca22840 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000018 si: 00007fd341d363f8 bp: 00007fd341d363e0 bx: 00003fed7ca22850 dx: 0000000000000000 ax: 00007fd341d363f8 cx: 00000000000006e8 sp: 00007fffcb1ae2b0 ip: 0000000002b03806 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000018 [end of stack trace] [1609/4198] MergeDictionaryTest.Merge (CRASHED) Original issue's description: > Enforce capability spec renderer <--> browser. > > This implements: > > - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer. > - adds such an overlay to chrome/browser > > So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review. > > R=rockot@chromium.org,tsepez@chromium.org > > Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3 > Cr-Commit-Position: refs/heads/master@{#418282} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2339593002 Cr-Commit-Position: refs/heads/master@{#418307}
- Loading branch information
lazyboy
authored and
Commit bot
committed
Sep 13, 2016
1 parent
cd4d1ad
commit b5eb9f6
Showing
29 changed files
with
47 additions
and
307 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.