Skip to content

Commit

Permalink
mac: Disable content_shell_crash_test on 10.10 and 10.11 bots.
Browse files Browse the repository at this point in the history
This test needs otool, and otool needs 10.14+ to run after the recent
Xcode bump.

We still run the test elsewhere, so not running it on the older bots
seems fine -- the test isn't very OS-version-dependent.

Bug: 1138050
Change-Id: I37c085fcf5c2850b42a21792fdcb28c9930005a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471798
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817110}
  • Loading branch information
nico authored and Commit Bot committed Oct 14, 2020
1 parent c581014 commit bbbc34e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 44 deletions.
44 changes: 0 additions & 44 deletions testing/buildbot/chromium.mac.json
Original file line number Diff line number Diff line change
Expand Up @@ -1534,28 +1534,6 @@
},
"test_id_prefix": "ninja://components:components_perftests/"
},
{
"isolate_name": "content_shell_crash_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "content_shell_crash_test",
"resultdb": {
"enable": false
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "none",
"os": "Mac-10.10"
}
],
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://content/shell:content_shell_crash_test/"
},
{
"isolate_name": "extension_docserver_python_unittests",
"merge": {
Expand Down Expand Up @@ -3260,28 +3238,6 @@
},
"test_id_prefix": "ninja://components:components_perftests/"
},
{
"isolate_name": "content_shell_crash_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "content_shell_crash_test",
"resultdb": {
"enable": false
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "none",
"os": "Mac-10.11"
}
],
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://content/shell:content_shell_crash_test/"
},
{
"isolate_name": "extension_docserver_python_unittests",
"merge": {
Expand Down
2 changes: 2 additions & 0 deletions testing/buildbot/test_suite_exceptions.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,8 @@
},
'content_shell_crash_test': {
'remove_from': [
'Mac10.10 Tests', # crbug.com/1138050
'Mac10.11 Tests', # crbug.com/1138050
'android-marshmallow-x86-rel-non-cq', # crbug.com/1084353
],
'modifications': {
Expand Down

0 comments on commit bbbc34e

Please sign in to comment.