From c07006b77f5a6af2a2206c3c32f1d4d6a4eb94f6 Mon Sep 17 00:00:00 2001 From: "jochen@chromium.org" Date: Wed, 20 Nov 2013 03:01:44 +0000 Subject: [PATCH] Add a gin/public directory When we start using gin from other projects but mojo, we want to be extra careful what we include. Therefore, we introduce a public/ directories with headers that are ok to be included from gin-embedders. As a start, we move wrapper_info.h into public/. BUG=317398 R=abarth@chromium.org Review URL: https://codereview.chromium.org/69293015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236114 0039d316-1c4b-4281-b951-d872f2087c98 --- gin/gin.gyp | 2 +- gin/modules/console.cc | 2 +- gin/modules/module_registry.cc | 2 +- gin/per_context_data.cc | 2 +- gin/per_isolate_data.h | 2 +- gin/{ => public}/wrapper_info.h | 6 +++--- gin/test/gtest.cc | 2 +- gin/wrapper_info.cc | 2 +- mojo/public/bindings/js/core.cc | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) rename gin/{ => public}/wrapper_info.h (81%) diff --git a/gin/gin.gyp b/gin/gin.gyp index ee55822874a97e..87589329e1b995 100644 --- a/gin/gin.gyp +++ b/gin/gin.gyp @@ -48,7 +48,7 @@ 'try_catch.cc', 'try_catch.h', 'wrapper_info.cc', - 'wrapper_info.h', + 'public/wrapper_info.h', ], }, { diff --git a/gin/modules/console.cc b/gin/modules/console.cc index 6f4afbbc9ca311..b3614a8abf422b 100644 --- a/gin/modules/console.cc +++ b/gin/modules/console.cc @@ -10,7 +10,7 @@ #include "gin/arguments.h" #include "gin/converter.h" #include "gin/per_isolate_data.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" using v8::ObjectTemplate; diff --git a/gin/modules/module_registry.cc b/gin/modules/module_registry.cc index 7ad7d790b32a07..fe9218cfb738ec 100644 --- a/gin/modules/module_registry.cc +++ b/gin/modules/module_registry.cc @@ -11,7 +11,7 @@ #include "gin/arguments.h" #include "gin/converter.h" #include "gin/per_isolate_data.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" using v8::Context; using v8::External; diff --git a/gin/per_context_data.cc b/gin/per_context_data.cc index 58a72418177cf5..4a76616df22515 100644 --- a/gin/per_context_data.cc +++ b/gin/per_context_data.cc @@ -5,7 +5,7 @@ #include "gin/per_context_data.h" #include "base/logging.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" namespace gin { diff --git a/gin/per_isolate_data.h b/gin/per_isolate_data.h index e758744bab2b46..7ed9da745df4c1 100644 --- a/gin/per_isolate_data.h +++ b/gin/per_isolate_data.h @@ -8,7 +8,7 @@ #include #include "base/basictypes.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" #include "v8/include/v8.h" namespace gin { diff --git a/gin/wrapper_info.h b/gin/public/wrapper_info.h similarity index 81% rename from gin/wrapper_info.h rename to gin/public/wrapper_info.h index 16eef25536658c..f1c554ee5de857 100644 --- a/gin/wrapper_info.h +++ b/gin/public/wrapper_info.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef GIN_WRAPPER_INFO_H_ -#define GIN_WRAPPER_INFO_H_ +#ifndef GIN_PUBLIC_WRAPPER_INFO_H_ +#define GIN_PUBLIC_WRAPPER_INFO_H_ #include "v8/include/v8.h" @@ -22,4 +22,4 @@ struct WrapperInfo { } // namespace gin -#endif // GIN_WRAPPER_INFO_H_ +#endif // GIN_PUBLIC_WRAPPER_INFO_H_ diff --git a/gin/test/gtest.cc b/gin/test/gtest.cc index c33a83dbadf0f8..2697282bab6e29 100644 --- a/gin/test/gtest.cc +++ b/gin/test/gtest.cc @@ -7,7 +7,7 @@ #include "gin/arguments.h" #include "gin/converter.h" #include "gin/per_isolate_data.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" #include "testing/gtest/include/gtest/gtest.h" using v8::ObjectTemplate; diff --git a/gin/wrapper_info.cc b/gin/wrapper_info.cc index d14156dcb26972..c1c6774643254c 100644 --- a/gin/wrapper_info.cc +++ b/gin/wrapper_info.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" namespace gin { diff --git a/mojo/public/bindings/js/core.cc b/mojo/public/bindings/js/core.cc index 6a048cfecbb73c..f9d7f1a67fe43a 100644 --- a/mojo/public/bindings/js/core.cc +++ b/mojo/public/bindings/js/core.cc @@ -9,7 +9,7 @@ #include "gin/converter.h" #include "gin/dictionary.h" #include "gin/per_isolate_data.h" -#include "gin/wrapper_info.h" +#include "gin/public/wrapper_info.h" #include "mojo/public/bindings/js/handle.h" namespace mojo {