Skip to content

Commit

Permalink
Allow RED internal format for CopyTextureCHROMIUM.
Browse files Browse the repository at this point in the history
In crrev.com/1434453008 we changed the internal format for images
from R8 to RED but we forgot to change glCopyTextureCHROMIUM internal
format validation.

This breaks video to WebGL on GL Core Profile since APPLE_ycbcr_422 is
not avaiable, we fall back to three R8 planes, and we then fail to validate
RED as internal format.

BUG=587158
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1703153002

Cr-Commit-Position: refs/heads/master@{#376026}
  • Loading branch information
DCastagna authored and Commit bot committed Feb 17, 2016
1 parent b9c0042 commit c98f752
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gpu/command_buffer/service/gles2_cmd_decoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13158,7 +13158,7 @@ bool GLES2DecoderImpl::ValidateCopyTextureCHROMIUMInternalFormats(
dest_internal_format == GL_RGBA ||
dest_internal_format == GL_BGRA_EXT;
bool valid_source_format =
source_internal_format == GL_R8 || source_internal_format == GL_ALPHA ||
source_internal_format == GL_RED || source_internal_format == GL_ALPHA ||
source_internal_format == GL_RGB || source_internal_format == GL_RGBA ||
source_internal_format == GL_LUMINANCE ||
source_internal_format == GL_LUMINANCE_ALPHA ||
Expand Down

0 comments on commit c98f752

Please sign in to comment.