Skip to content

Commit

Permalink
Remove unneeded //chrome dependency from sync_integration_tests_support.
Browse files Browse the repository at this point in the history
Also, assert_no_deps checks to the tests from chromium_builder_perf collection for them being from a dependency on //chrome.

This should speed up 'LTO Perf' builder, as linking some of the tests will start earlier.

BUG=453195
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1968803003
Cr-Commit-Position: refs/heads/master@{#393161}
  • Loading branch information
gkrasin authored and Commit bot committed May 12, 2016
1 parent a82ed96 commit ca63e41
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 1 deletion.
3 changes: 3 additions & 0 deletions cc/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,9 @@ test("cc_perftests") {
"//ui/gl",
"//ui/gl:test_support",
]

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
# When adding support for isolates, please have a look at run-time dependencies
# in the cc_unittests_run target in cc_tests.gyp.
10 changes: 9 additions & 1 deletion chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,6 @@ if (!is_android) {
deps = [
":test_support",
"//base",
"//chrome",
"//components/invalidation/impl",
"//components/invalidation/impl:test_support",
"//content/test:browsertest_base",
Expand Down Expand Up @@ -1549,6 +1548,9 @@ if (!is_android) {
if (toolkit_views) {
deps += [ "//ui/views" ]
}

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}

# Executable to measure time to load libraries.
Expand All @@ -1570,6 +1572,9 @@ if (!is_android) {
"//third_party/widevine/cdm:widevinecdmadapter",
]
}

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
}

Expand Down Expand Up @@ -2309,6 +2314,9 @@ if (is_win || (is_linux && !is_chromeos)) {
if (!is_mac) {
sources -= [ "perf/mach_ports_performancetest.cc" ]
}

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
}

Expand Down
3 changes: 3 additions & 0 deletions gpu/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -389,4 +389,7 @@ test("gpu_perftests") {
"//ui/gfx/geometry",
"//ui/gl",
]

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
3 changes: 3 additions & 0 deletions media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,9 @@ test("media_perftests") {
if (media_use_ffmpeg) {
deps += [ "//third_party/ffmpeg" ] # Direct dependency required to inherit config.
}

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}

# For running the subset of media_unittests that might require audio hardware
Expand Down
3 changes: 3 additions & 0 deletions media/midi/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,7 @@ test("midi_unittests") {
if (use_x11) {
deps += [ "//tools/xdisplaycheck" ]
}

# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}

0 comments on commit ca63e41

Please sign in to comment.