Skip to content

Commit

Permalink
Unflake some tests
Browse files Browse the repository at this point in the history
Also skip lofi fallback test in M74, that fails due to server support
removed.

Bug: 934875
Change-Id: Ic5d0d00d63d95cf458e0afc3eaf0a3cf16743c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611078
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659254}
  • Loading branch information
rajendrant authored and Commit Bot committed May 13, 2019
1 parent 91aa339 commit d1745f8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/chrome_proxy/webdriver/lite_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ def testStaleLitePageNano(self):
test_driver.LoadURL(
'http://check.googlezip.net/cacheable/test.html?age_seconds=360')

test_driver.SleepUntilHistogramHasEntry(
'Previews.StalePreviewTimestampShown')
histogram = test_driver.GetBrowserHistogram(
'Previews.StalePreviewTimestampShown')
self.assertEqual(1, histogram['count'])
Expand All @@ -158,7 +160,7 @@ def testStaleLitePageNano(self):
# Verifies Lo-Fi fallback via the page-policies server directive.
# Note: this test is for the CPAT protocol change in M-61.
@ChromeVersionEqualOrAfterM(61)
@ChromeVersionBeforeM(75)
@ChromeVersionBeforeM(74)
def testLitePageFallbackViaPagePolicies(self):
with TestDriver() as test_driver:
test_driver.AddChromeArg('--enable-spdy-proxy-auth')
Expand Down
1 change: 1 addition & 0 deletions tools/chrome_proxy/webdriver/smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def testPingback(self):
t.LoadURL('http://check.googlezip.net/test.html')
t.LoadURL('http://check.googlezip.net/test.html')
t.SleepUntilHistogramHasEntry("DataReductionProxy.Pingback.Succeeded")
t.SleepUntilHistogramHasEntry("DataReductionProxy.Pingback.Attempted")
# Verify one pingback attempt that was successful.
attempted = t.GetBrowserHistogram('DataReductionProxy.Pingback.Attempted')
self.assertEqual(1, attempted['count'])
Expand Down

0 comments on commit d1745f8

Please sign in to comment.