Skip to content

Commit

Permalink
RubyNG+FragmentItem: Fix annotation space computation
Browse files Browse the repository at this point in the history
With FragmentItem, a NGLogicalLineItems contains an InlineBox wrapping
a RubyRun.  It should be skipped on annotation space computation.

Bug: 1102887
Change-Id: Ia2b5f61090e9cd1a66e9415c64bcc2ea2c90efe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288937
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786669}
  • Loading branch information
tkent-google authored and Commit Bot committed Jul 9, 2020
1 parent aa4e1e2 commit d1a787d
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ NGAnnotationMetrics ComputeAnnotationOverflow(
else if (overflow > LayoutUnit())
has_under_annotation = true;
}
} else if (item.IsInlineBox()) {
continue;
}
}
content_over = std::min(content_over, item_over);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ crbug.com/982194 external/wpt/webrtc/simulcast/h264.https.html [ Failure ]
crbug.com/982194 external/wpt/webvtt/rendering/cues-with-video/processing-model/cue_too_long.html [ Failure Pass ]
crbug.com/982194 external/wpt/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html [ Failure Pass ]
crbug.com/982194 fast/scrolling/document-level-touchmove-event-listener-passive-by-default.html [ Failure Pass ]
crbug.com/1102887 fast/ruby/ruby-position-modern-japanese-fonts.html [ Failure ]
crbug.com/982194 http/tests/security/mixedContent/insecure-css-resources.html [ Failure Pass ]
crbug.com/982194 inspector-protocol/media/media-player.js [ Pass ]
crbug.com/1061102 media/picture-in-picture/v2/detached-iframe.html [ Skip ]
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit d1a787d

Please sign in to comment.