Skip to content

Commit

Permalink
android: Don't print link to logdog stream during tests if it's empty.
Browse files Browse the repository at this point in the history
See https://chromium-swarm-dev.appspot.com/task?id=39bce1ee054c5e10

R=jbudorick@chromium.org

Bug: 
Change-Id: If635938d30fbe2b527ef972d5c4896b599f42642
Reviewed-on: https://chromium-review.googlesource.com/764575
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515796}
  • Loading branch information
bpastene authored and Commit Bot committed Nov 11, 2017
1 parent 6f7865f commit d600872
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion build/android/pylib/local/device/local_device_gtest_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,8 @@ def _RunTest(self, device, test):
timeout=timeout, retries=0)
logmon.Close()

logging.info('Logcat saved to %s', logcat_file.Link())
if logcat_file.Link():
logging.info('Logcat saved to %s', logcat_file.Link())

if self._test_instance.enable_xml_result_parsing:
try:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,8 @@ def name_and_timeout(t):
target, raw=True, extras=extras, timeout=timeout, retries=0)
logmon.Close()

logging.info('Logcat saved to %s', logcat_file.Link())
if logcat_file.Link():
logging.info('Logcat saved to %s', logcat_file.Link())

duration_ms = time_ms() - start_ms

Expand Down

0 comments on commit d600872

Please sign in to comment.