Skip to content

Commit

Permalink
Disable TCPSocketTest.BeforeConnectCallback on Fuchsia.
Browse files Browse the repository at this point in the history
This test fails becasue MSG_PEEK is not implemented.

Bug: 887587
Change-Id: I6e1ba04afc1f34a11352ba0280dfc33c4436affa
Reviewed-on: https://chromium-review.googlesource.com/1235210
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592895}
  • Loading branch information
Steelskin authored and Commit Bot committed Sep 20, 2018
1 parent f218afd commit da20b6a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/socket/socket_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ bool SocketPosix::IsConnected() const {
// 1. Check if the connection is alive using poll(POLLRDHUP).
// 2. If closed, then use ioctl(FIONREAD) to check if there is data to be
// read.
// TODO(bug 738275): Remove once MSG_PEEK is implemented on Fuchsia.
// TODO(crbug.com/887587): Remove once MSG_PEEK is implemented on Fuchsia.
struct pollfd pollfd;
pollfd.fd = socket_fd_;
pollfd.events = POLLRDHUP;
Expand Down Expand Up @@ -297,7 +297,7 @@ bool SocketPosix::IsConnectedAndIdle() const {
// socket. POLLIN is signaled if the socket is readable or if it was closed by
// the peer, i.e. the socket is connected and idle if and only if POLLIN is
// not signaled.
// TODO(bug 738275): Remove once MSG_PEEK is implemented.
// TODO(crbug.com/887587): Remove once MSG_PEEK is implemented.
struct pollfd pollfd;
pollfd.fd = socket_fd_;
pollfd.events = POLLIN;
Expand Down
4 changes: 4 additions & 0 deletions testing/buildbot/filters/fuchsia.net_unittests.filter
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@

# Flaky, https://crbug.com/814811.
-URLRequestTest.NetworkDelegateProxyError

# SocketPosix::IsConnected has a different behavior on Fuchsia.
# https://crbug.com/887587.
-TCPSocketTest.BeforeConnectCallback

0 comments on commit da20b6a

Please sign in to comment.