Skip to content

Commit

Permalink
[Chromecast] Disable PartitionAllocTest.RepeatedReturnNullDirect.
Browse files Browse the repository at this point in the history
This test is flaking on the CQ. Disable it on desktop until we can
assess the root cause.

BUG= b/67975693

Bug: 67975693
Test: CQ
Change-Id: I76ad684140460b10b819c45f77a75bff5a7fb935
Reviewed-on: https://chromium-review.googlesource.com/727076
Commit-Queue: Stephen Lanham <slan@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510143}
  • Loading branch information
Stephen Lanham authored and Commit Bot committed Oct 19, 2017
1 parent 2fef572 commit dcfc3cd
Showing 1 changed file with 23 additions and 17 deletions.
40 changes: 23 additions & 17 deletions chromecast/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -159,23 +159,29 @@ cast_test_group("cast_tests") {

base_unittests_filter = {
test_name = "base_unittests"
if (target_os == "linux" && !is_cast_desktop_build) {
# Disable ProcessMetricsTest.GetNumberOfThreads (b/15610509)
# Disable ProcessUtilTest.* (need to define OS_ANDROID)
# Disable StackContainer.BufferAlignment (don't support 16-byte alignment)
# Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guaranteed)
# Disable TimeFormattingTest.TimeFormat* for flakiness on devices (crbug/671429)
# Disable PostTasksViaTaskRunner/* to green up devices (b/62246873)
# Disable WorkerDetaches to green up devices (b/62246873)
gtest_excludes = [
"ProcessMetricsTest.GetNumberOfThreads",
"ProcessUtilTest.*",
"StackContainer.BufferAlignment",
"SystemMetrics2Test.GetSystemMemoryInfo",
"TimeFormattingTest.TimeFormat*",
"OneTraitsExecutionModePair/TaskSchedulerImplTest.PostTasksViaTaskRunner/*",
"TaskSchedulerWorkerTest.WorkerDetaches",
]
gtest_excludes = []
if (target_os == "linux") {
if (is_cast_desktop_build) {
# Disable PartitionAllocTest.RepeatedReturnNullDirect (b/67975693)
gtest_excludes += [ "PartitionAlloc.RepeatedReturnNullDirect" ]
} else {
# Disable ProcessMetricsTest.GetNumberOfThreads (b/15610509)
# Disable ProcessUtilTest.* (need to define OS_ANDROID)
# Disable StackContainer.BufferAlignment (don't support 16-byte alignment)
# Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guaranteed)
# Disable TimeFormattingTest.TimeFormat* for flakiness on devices (crbug/671429)
# Disable PostTasksViaTaskRunner/* to green up devices (b/62246873)
# Disable WorkerDetaches to green up devices (b/62246873)
gtest_excludes += [
"ProcessMetricsTest.GetNumberOfThreads",
"ProcessUtilTest.*",
"StackContainer.BufferAlignment",
"SystemMetrics2Test.GetSystemMemoryInfo",
"TimeFormattingTest.TimeFormat*",
"OneTraitsExecutionModePair/TaskSchedulerImplTest.PostTasksViaTaskRunner/*",
"TaskSchedulerWorkerTest.WorkerDetaches",
]
}

if (is_cast_audio_only) {
# Also disable TimeFormattingTest on audio-only builds, since we don't
Expand Down

0 comments on commit dcfc3cd

Please sign in to comment.