Skip to content

Commit

Permalink
Replace CHECK by DumpWithoutCrashing in NavigationRequest.
Browse files Browse the repository at this point in the history
The root cause of https://crbug.com/936962 hasn't been found yet. It
fails because of a 'CHECK'. This CL replaces it by a DumpWithoutCrashing.
The goal is to avoid bothering M74 beta users with browser crashes.
Of course, a solution to this bug must be found in the meantime.

This is intented to be merged into M74.

Bug: 936962
Change-Id: Ie47971aeaaf730f17a3060bc440338be0eebe412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528231
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641881}
  • Loading branch information
ArthurSonzogni authored and Commit Bot committed Mar 19, 2019
1 parent b525fba commit e890706
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion content/browser/frame_host/navigation_request.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,10 @@ void NavigationRequest::OnRequestFailedInternal(
// Sanity check that we haven't changed the RenderFrameHost picked for the
// error page in OnRequestFailedInternal when running the WillFailRequest
// checks.
CHECK(!render_frame_host_ || render_frame_host_ == render_frame_host);
// TODO(https://crbug.com/636952): Replace this by a CHECK when the bug is
// fixed.
if (render_frame_host_ && render_frame_host_ != render_frame_host)
base::debug::DumpWithoutCrashing();
render_frame_host_ = render_frame_host;

DCHECK(render_frame_host_);
Expand Down

0 comments on commit e890706

Please sign in to comment.