Skip to content

Commit

Permalink
Page Info Android: Fix RTL positioning for untranslated permission na…
Browse files Browse the repository at this point in the history
…mes.

Hebrew does not translate the string for 'Javascript'. This means any labels
containing the English string will not have the RTL mark, and it will be
displayed in LTR mode. Normally this would be OK, however, the permission labels
in Page Info for Android have a width that matches the parent, so the label ends
up aligning the text all the way on the left.

Fix by changing the label width to wrap the content instead of matching its
parent width. Note other strings are fine because they have Hebrew translations.

Bug: 774934
Change-Id: I756c9e9584c8c89ab86462ba43aa8cefc10f024e
Reviewed-on: https://chromium-review.googlesource.com/776333
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521265}
  • Loading branch information
plorcupine authored and Commit Bot committed Dec 4, 2017
1 parent 5c9bae6 commit eab030f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<TextView
android:id="@+id/page_info_permission_status"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_toEndOf="@id/page_info_permission_icon"
android:textAppearance="@style/BlackBodyDefault" />
Expand Down

0 comments on commit eab030f

Please sign in to comment.