Skip to content

Commit

Permalink
Add a space before seconds units like all other units.
Browse files Browse the repository at this point in the history
BUG=none
TEST=none (no unit tests for operator<< exist)

Review-Url: https://codereview.chromium.org/2549203002
Cr-Commit-Position: refs/heads/master@{#436790}
  • Loading branch information
drcrash authored and Commit bot committed Dec 7, 2016
1 parent e8f783e commit ec7a5bc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion base/time/time.cc
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ int64_t SaturatedSub(TimeDelta delta, int64_t value) {
} // namespace time_internal

std::ostream& operator<<(std::ostream& os, TimeDelta time_delta) {
return os << time_delta.InSecondsF() << "s";
return os << time_delta.InSecondsF() << " s";
}

// Time -----------------------------------------------------------------------
Expand Down
6 changes: 3 additions & 3 deletions base/time/time_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1116,17 +1116,17 @@ TEST(TimeDeltaLogging, DCheckEqCompiles) {

TEST(TimeDeltaLogging, EmptyIsZero) {
TimeDelta zero;
EXPECT_EQ("0s", AnyToString(zero));
EXPECT_EQ("0 s", AnyToString(zero));
}

TEST(TimeDeltaLogging, FiveHundredMs) {
TimeDelta five_hundred_ms = TimeDelta::FromMilliseconds(500);
EXPECT_EQ("0.5s", AnyToString(five_hundred_ms));
EXPECT_EQ("0.5 s", AnyToString(five_hundred_ms));
}

TEST(TimeDeltaLogging, MinusTenSeconds) {
TimeDelta minus_ten_seconds = TimeDelta::FromSeconds(-10);
EXPECT_EQ("-10s", AnyToString(minus_ten_seconds));
EXPECT_EQ("-10 s", AnyToString(minus_ten_seconds));
}

TEST(TimeDeltaLogging, DoesNotMessUpFormattingFlags) {
Expand Down

0 comments on commit ec7a5bc

Please sign in to comment.