From efe0448d4f345f769d1073d86259a28653eec430 Mon Sep 17 00:00:00 2001
From: Shaobo <shaobo.yan@intel.com>
Date: Mon, 22 Aug 2022 03:20:24 +0000
Subject: [PATCH] Remove RenderAttachment usage for multi-planar format
 resource

This CL fix a bug about adding RenderAttachment usage when importing
multi-planar resource into Dawn. The bug causes validation error and
fails import op.

Bug: chromium:1354412
Change-Id: I58a0701195c53a94199ed70b4c8757010aac1081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840195
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1037545}
---
 .../shared_image/iosurface_image_backing_factory.mm       | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm b/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
index 173d473c50efc4..fdf5fd6411682f 100644
--- a/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
+++ b/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
@@ -125,9 +125,11 @@ WGPUTexture BeginAccess(WGPUTextureUsage usage) final {
     // copyTextureForBrowser.
     WGPUDawnTextureInternalUsageDescriptor internalDesc = {};
     internalDesc.chain.sType = WGPUSType_DawnTextureInternalUsageDescriptor;
-    internalDesc.internalUsage = WGPUTextureUsage_CopySrc |
-                                 WGPUTextureUsage_RenderAttachment |
-                                 WGPUTextureUsage_TextureBinding;
+    internalDesc.internalUsage =
+        WGPUTextureUsage_CopySrc | WGPUTextureUsage_TextureBinding;
+    if (wgpu_format_ != WGPUTextureFormat_R8BG8Biplanar420Unorm) {
+      internalDesc.internalUsage |= WGPUTextureUsage_RenderAttachment;
+    }
 
     texture_descriptor.nextInChain =
         reinterpret_cast<WGPUChainedStruct*>(&internalDesc);