forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Don't PostTask the RenderWidget::Close() call."
This is a reland of 8f0dc96 Original change's description: > Don't PostTask the RenderWidget::Close() call. > > The post task in RenderWidget was in order to keep IPC receipt of > destruction of a frame-based RenderWidget (ie a RenderView in the past) > from happening while the RenderWidget was already closing due to the > renderer-side detaching, but running a nested message loop. > > The RenderView destruction now already does a PostTask hop in > RenderThreadImpl before starting destruction of the RenderViewImpl > and its frame tree and RenderWidgets. A RenderWidget for a frame closes > when the frame detaches, and that is built to be consistent even if > it occurs inside of unload. The RenderWidget does not need to be kept > around after the blink frame and RenderFrame and WebWidget associated > with it are all gone. > > Popups and pepper RenderWidgets can close during a frame unload without > a consistency problem. > > R=dcheng@chromium.org > > Bug: 419087 > Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702868} TBR=dcheng Bug: 419087 Change-Id: I0f68df454e2873d7e6f3eeb38ff41563c16f6a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841942 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#702977}
- Loading branch information
Showing
15 changed files
with
213 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.