Skip to content

Commit

Permalink
[iOS] Adds 'Open Image' symbol
Browse files Browse the repository at this point in the history
Bug: 1315544
Change-Id: I18b3b632d29bcd8c0bde919b22b7b5b9f782bb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3657447
Auto-Submit: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005748}
  • Loading branch information
Ewann authored and Chromium LUCI CQ committed May 20, 2022
1 parent 81f673d commit f2c6265
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions ios/chrome/browser/ui/icons/action_icon.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ extern NSString* kRequestMobileActionSymbol;
extern NSString* kFindInPageActionSymbol;
extern NSString* kZoomTextActionSymbol;
extern NSString* kSaveImageActionSymbol;
extern NSString* kOpenImageActionSymbol;

#endif // IOS_CHROME_BROWSER_UI_ICONS_ACTION_ICON_H_
1 change: 1 addition & 0 deletions ios/chrome/browser/ui/icons/action_icon.mm
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@
NSString* kFindInPageActionSymbol = @"doc.text.magnifyingglass";
NSString* kZoomTextActionSymbol = @"plus.magnifyingglass";
NSString* kSaveImageActionSymbol = @"square.and.arrow.down";
NSString* kOpenImageActionSymbol = @"arrow.up.right.square";
6 changes: 5 additions & 1 deletion ios/chrome/browser/ui/menu/browser_action_factory.mm
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,13 @@ - (UIAction*)actionOpenImageWithURL:(const GURL)URL
completion:(ProceduralBlock)completion {
UrlLoadingBrowserAgent* loadingAgent =
UrlLoadingBrowserAgent::FromBrowser(self.browser);
UIImage* image = UseSymbols()
? DefaultSymbolWithPointSize(kOpenImageActionSymbol,
kSymbolActionPointSize)
: [UIImage imageNamed:@"open"];
UIAction* action = [self
actionWithTitle:l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_OPENIMAGE)
image:[UIImage imageNamed:@"open"]
image:image
type:MenuActionType::OpenImageInCurrentTab
block:^{
loadingAgent->Load(UrlLoadParams::InCurrentTab(URL));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ void SetUp() override {

GURL testURL = GURL("https://example.com/logo.png");

UIImage* expectedImage = [UIImage imageNamed:@"open"];
UIImage* expectedImage = DefaultSymbolWithPointSize(kOpenImageActionSymbol,
kSymbolActionPointSize);
NSString* expectedTitle =
l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_OPENIMAGE);

Expand Down

0 comments on commit f2c6265

Please sign in to comment.