Skip to content

Commit

Permalink
Fix a findbugs error in Addr2LineWorkerPool.java.
Browse files Browse the repository at this point in the history
Review URL: https://codereview.chromium.org/268533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267664 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
thestig@chromium.org committed May 1, 2014
1 parent 8110218 commit f44a527
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion build/android/findbugs_filter/findbugs_known_bugs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,3 @@ M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final
M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context) At ProfileSyncService.java
M B OS: org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() may fail to close stream At Addr2LineWorkerPool.java
M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new org.chromium.tools.binary_size.NmDumper$Output(NmDumper) At NmDumper.java
M D REC: Exception is caught when Exception is not thrown in org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() At Addr2LineWorkerPool.java
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ public void run() {
inStream = null; // New readers need to be created next iteration
}
}
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
e.printStackTrace();
} finally {
Expand Down Expand Up @@ -464,4 +466,4 @@ int getDisambiguationFailureCount() {
int getDedupeCount() {
return mDedupeCount.get();
}
}
}

0 comments on commit f44a527

Please sign in to comment.