From f44a527dafde3d0b32f5dd4449dcbfde72c0f1f6 Mon Sep 17 00:00:00 2001 From: "thestig@chromium.org" Date: Thu, 1 May 2014 23:36:55 +0000 Subject: [PATCH] Fix a findbugs error in Addr2LineWorkerPool.java. Review URL: https://codereview.chromium.org/268533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267664 0039d316-1c4b-4281-b951-d872f2087c98 --- build/android/findbugs_filter/findbugs_known_bugs.txt | 1 - .../org/chromium/tools/binary_size/Addr2LineWorkerPool.java | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt index 0fbd91498ed8f9..a8cc70a66fd4bd 100644 --- a/build/android/findbugs_filter/findbugs_known_bugs.txt +++ b/build/android/findbugs_filter/findbugs_known_bugs.txt @@ -31,4 +31,3 @@ M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context) At ProfileSyncService.java M B OS: org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() may fail to close stream At Addr2LineWorkerPool.java M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new org.chromium.tools.binary_size.NmDumper$Output(NmDumper) At NmDumper.java -M D REC: Exception is caught when Exception is not thrown in org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() At Addr2LineWorkerPool.java diff --git a/tools/binary_size/java/src/org/chromium/tools/binary_size/Addr2LineWorkerPool.java b/tools/binary_size/java/src/org/chromium/tools/binary_size/Addr2LineWorkerPool.java index 4f0e517c79fbfb..626e7e42dc7025 100644 --- a/tools/binary_size/java/src/org/chromium/tools/binary_size/Addr2LineWorkerPool.java +++ b/tools/binary_size/java/src/org/chromium/tools/binary_size/Addr2LineWorkerPool.java @@ -276,6 +276,8 @@ public void run() { inStream = null; // New readers need to be created next iteration } } + } catch (RuntimeException e) { + throw e; } catch (Exception e) { e.printStackTrace(); } finally { @@ -464,4 +466,4 @@ int getDisambiguationFailureCount() { int getDedupeCount() { return mDedupeCount.get(); } -} \ No newline at end of file +}