Skip to content

Commit

Permalink
Revert "Reland Update axe-core to v3.3.2"
Browse files Browse the repository at this point in the history
This reverts commit de35a09.

Reason for revert:
Failing on all platforms.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WelcomeA11y.WelcomeFlow_color_contrast
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27248
[18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page
Error: the string "Found 1 accessibility violations." was thrown, throw an Error :)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49)
[18374:18374:0923/204432.101101:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/1 tests had failed assertions.
[18374:18374:0923/204432.101355:ERROR:web_ui_browser_test.cc(546)] CONDITION FAILURE: encountered javascript console error(s):
[18374:18374:0923/204432.101376:ERROR:web_ui_browser_test.cc(548)] JS ERROR: '[18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page
Error: the string "Found 1 accessibility violations." was thrown, throw an Error :)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49)
'
[18374:18374:0923/204432.101390:ERROR:web_ui_browser_test.cc(550)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/welcome/a11y_tests-gen.cc:285: Failure
Value of: RunJavascriptTestF( true, "WelcomeA11y", "WelcomeFlow_color_contrast")
  Actual: false
Expected: true
Stack trace:
#0 0x55ebe3920b5f StackTraceGetter::CurrentStackTrace()
chromium#1 0x55ebe392955c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
chromium#2 0x55ebe3928ea9 testing::internal::AssertHelper::operator=()
chromium#3 0x55ebe36c24dd WelcomeA11y_WelcomeFlow_color_contrast_Test::RunTestOnMainThread()
chromium#4 0x55ebe60b131e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
chromium#5 0x55ebe5cae39c ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
chromium#6 0x55ebe5cad1ad ChromeBrowserMainParts::PreMainMessageLoopRun()
chromium#7 0x55ebe438318f content::BrowserMainLoop::PreMainMessageLoopRun()
chromium#8 0x55ebe4779607 content::StartupTaskRunner::RunAllTasksNow()
chromium#9 0x55ebe4381e42 content::BrowserMainLoop::CreateStartupTasks()
chromium#10 0x55ebe4384bf2 content::BrowserMainRunnerImpl::Initialize()
chromium#11 0x55ebe438041f content::BrowserMain()
chromium#12 0x55ebe5873245 content::ContentMainRunnerImpl::RunServiceManager()
chromium#13 0x55ebe5872d76 content::ContentMainRunnerImpl::Run()
chromium#14 0x55ebe7a2e8dd service_manager::Main()
chromium#15 0x55ebe4c9c511 content::ContentMain()
chromium#16 0x55ebe60b0dc6 content::BrowserTestBase::SetUp()

Original change's description:
> Reland Update axe-core to v3.3.2
> 
> This change updates the version of axe-core to the latest released
> version. As part of picking up the latest version, the following
> additional changes were made:
> 
> 1) axe-core removed the 'href-no-hash' rule, so that been removed
>    from the test list.
> 
> 2) Several 'link-in-text-block' tests started failing with
>    axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but
>    are disabled as part of this change.
>      - CrManagementA11yTest.SimpleTest_link_in_text_block
>      - CrManagementA11yTestWithExtension.
>                                 ExtensionSection_link_in_text_block
>      - CrostiniAccessibilityTest.CROSTINI_link_in_text_block
>      - CrExtensionsA11yTest.NoExtensions_link_in_text_block
>      - MultideviceA11yTest.MULTIDEVICE_link_in_text_block
>      - MultideviceFeaturesA11yTest.
>               MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block
> 
> 3) One 'heading-order' test started failing in v3.0.0 (and later).
>    This tests does pass in V2.4.2, but is disabled as part of this
>    change.
>      - CrExtensionsA11yTestWithMultipleExensions.
>                                        WithExtensions_heading_order
> 
> 4) Several DevTools a11y tests were failing. This change either
>    updates the baseline or excludes the rule depending upon the
>    test/rule itself.
>      - http/tests/devtools/a11y-axe-core/basic-a11y-test.js
>      - http/tests/devtools/a11y-axe-core/console-a11y-test.js
>      - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js
>      - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js
> 
> I spent some time investigating the test failures, and it looks
> like axe-core is highlighting legitimate product issues.
> 
> Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b
> Bug: 984817
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407
> Commit-Queue: Mike Jackson <mjackson@microsoft.com>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699166}

TBR=aboxhall@chromium.org,hcarmona@chromium.org,yangguo@chromium.org,mjackson@microsoft.com,tvanderlippe@chromium.org

Change-Id: I6e74d1ddeec80407fc057dd07c95c492d7e6679f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819284
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699191}
  • Loading branch information
alancutter authored and Commit Bot committed Sep 24, 2019
1 parent 2fd10c0 commit fc9a09a
Show file tree
Hide file tree
Showing 19 changed files with 3,193 additions and 10,138 deletions.
2 changes: 0 additions & 2 deletions chrome/test/data/webui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ js2gtest("browser_tests_js_webui") {
"webui_resource_async_browsertest.js",
]

gen_include_files = [ "a11y/accessibility_audit_rules.js" ]

extra_js_files = [
"test_browser_proxy.js",
"settings/test_password_manager_proxy.js",
Expand Down
1 change: 1 addition & 0 deletions chrome/test/data/webui/a11y/accessibility_audit_rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ AccessibilityTest.ruleIds = [
'frame-title',
'heading-order',
'hidden-content',
'href-no-hash',
'html-has-lang',
'html-lang-valid',
'image-alt',
Expand Down
18 changes: 1 addition & 17 deletions chrome/test/data/webui/extensions/a11y/extensions_a11y_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,6 @@ var CrExtensionsA11yTest = class extends PolymerTest {
return parentNode && parentNode.host &&
parentNode.host.tagName == 'CR-TOGGLE';
},

// TODO(crbug.com/1002620): this filter can be removed after
// addressing the bug
'heading-order': function(nodeResult) {
// Filter out 'Heading levels do not increase by one' error when
// enumerating extensions
const expectedMarkup = '<div id="name" role="heading" aria-level="3" \
class="clippable-flex-text">My extension 1</div>';
return nodeResult['html'] === expectedMarkup;
},
};
}

Expand Down Expand Up @@ -95,13 +85,7 @@ AccessibilityTest.define('CrExtensionsA11yTest', {
name: 'NoExtensions',

/** @override */
// TODO(crbug.com/1002627): when bug is addressed, this should be replaced
// with axeOptions: CrExtensionsA11yTest.axeOptions,
axeOptions: Object.assign({}, CrExtensionsA11yTest.axeOptions, {
'rules': Object.assign({}, CrExtensionsA11yTest.axeOptions.rules, {
'link-in-text-block': {enabled: false},
})
}),
axeOptions: CrExtensionsA11yTest.axeOptions,

/** @override */
violationFilter: CrExtensionsA11yTest.violationFilter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ var CrManagementA11yTest = class extends PolymerTest {
'skip-link': {enabled: false},
// TODO(crbug.com/761461): enable after addressing flaky tests.
'color-contrast': {enabled: false},
// TODO(crbug.com/1002623): remove this line after addressing bug
'link-in-text-block': {enabled: false},
},
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ AccessibilityTest.define('CrostiniAccessibilityTest', {
/** @override */
name: 'CROSTINI',
/** @override */
axeOptions: SettingsAccessibilityTest.axeOptionsExcludeLinkInTextBlock,
axeOptions: SettingsAccessibilityTest.axeOptions,
/** @override */
setup: function() {
settings.router.navigateTo(settings.routes.CROSTINI);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ AccessibilityTest.define('MultideviceA11yTest', {
/** @override */
name: 'MULTIDEVICE',
/** @override */
axeOptions: SettingsAccessibilityTest.axeOptionsExcludeLinkInTextBlock,
axeOptions: SettingsAccessibilityTest.axeOptions,
/** @override */
setup: function() {
settings.router.navigateTo(settings.routes.MULTIDEVICE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ AccessibilityTest.define('MultideviceFeaturesA11yTest', {
/** @override */
name: 'MULTIDEVICE_FEATURES_ACCESSIBILITY',
/** @override */
axeOptions: SettingsAccessibilityTest.axeOptionsExcludeLinkInTextBlock,
axeOptions: SettingsAccessibilityTest.axeOptions,
/** @override */
setup: function() {
settings.router.navigateTo(settings.routes.MULTIDEVICE_FEATURES);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,6 @@ SettingsAccessibilityTest.axeOptions = {
}
};

// TODO(crbug.com/1002627): This block prevents generation of a
// link-in-text-block browser-test. This can be removed once the bug is
// addressed, and usage should be replaced with
// SettingsAccessibilityTest.axeOptions
SettingsAccessibilityTest.axeOptionsExcludeLinkInTextBlock =
Object.assign({}, SettingsAccessibilityTest.axeOptions, {
'rules': Object.assign({}, SettingsAccessibilityTest.axeOptions.rules, {
'link-in-text-block': {enabled: false},
})
});

// Default accessibility audit options. Specify in test definition to use.
SettingsAccessibilityTest.violationFilter = {
// Polymer components use aria-active-attribute.
Expand Down
6 changes: 3 additions & 3 deletions third_party/axe-core/README.chromium
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Name: AXE-CORE Accessibility Audit
Short Name: axe-core
URL: https://github.com/dequelabs/axe-core/
Version: 3.3.2
Date: Thur Aug 22 12:45:00 2019
Revision: 281653df3794f429b71327fe3afa37ca0fadb1c7
Version: 0
Date: Mon Jul 24 12:17:05 2017
Revision: d02dba3223fefe525438330e40b5da5de81eeeb5
License: MPL 2.0
License File: LICENSE
Security Critical: no
Expand Down
Loading

0 comments on commit fc9a09a

Please sign in to comment.