Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar position option, experimental Cypress test browser support #23

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

MikeShi42
Copy link
Contributor

@MikeShi42 MikeShi42 commented Apr 21, 2022

  • Ability to choose where your overlay bar is positioned (top or bottom)
  • Added ability to specify preferred library, so we'll always show test code of you're preferred library
  • Experimental support for using the recorder within the Cypress test browser (Chrome & FF)
  • Makes code gen classes always generate semicolons

Closes #20

@MikeShi42 MikeShi42 requested a review from wrn14897 April 21, 2022 07:34
@@ -395,7 +395,7 @@ export class PlaywrightScriptBuilder extends ScriptBuilder {
};

awaitText = (text: string) => {
this.pushCodes(`await page.waitForSelector('text=${text}')`);
this.pushCodes(`await page.waitForSelector('text=${text}');`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress official style guide doesn't encourage semicolon cypress-io/cypress-documentation#853 and that's why I didn't add it (all their example codes don't have semicolon)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly it looks like it's roughly 50/50 if the it() block should have a semicolon or not. I think I've added it for consistency with everything else having a semicolon but 🤷‍♂️

@MikeShi42 MikeShi42 merged commit 678cd4a into main Apr 21, 2022
@MikeShi42 MikeShi42 deleted the mikeshi-bar-position-cypress branch April 21, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Control Bar to be Moved/Hidden
2 participants