Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND DOCS command #146

Open
arpitbbhayani opened this issue Jul 12, 2024 · 13 comments
Open

Add support for COMMAND DOCS command #146

arpitbbhayani opened this issue Jul 12, 2024 · 13 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the COMMAND DOCS command in DiceDB similar to the COMMAND DOCS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@Dhravya
Copy link

Dhravya commented Jul 13, 2024

hi! i would love to take this one

@JyotinderSingh
Copy link
Collaborator

hi! i would love to take this one

Hi, thanks for taking this up. I've assigned the issue to you.

@JyotinderSingh
Copy link
Collaborator

Unassigned due to inactivity. This issue is available for anyone to pick up.

@BiswajitSahoo-tech
Copy link

Hey @JyotinderSingh, can I pick this up ?

@JyotinderSingh
Copy link
Collaborator

Hey @JyotinderSingh, can I pick this up ?

Assigned

@AshwinKul28
Copy link
Contributor

@BiswajitSahoo-tech thanks for picking this up. Can you please add any latest updates on this? Let us know if you have any blockers on this we can discuss this over the discord.

@kailashchoudhary11
Copy link

Hey, I would like to take this up if no one is working on it rn.

@AshwinKul28
Copy link
Contributor

@JyotinderSingh Please assign @kailashchoudhary11 .
also need to check why I cannot change the assignee? Maybe some permission issue.

@JyotinderSingh
Copy link
Collaborator

Hey, I would like to take this up if no one is working on it rn.

Assigned

@arpitbbhayani
Copy link
Contributor Author

@kailashchoudhary11 any updates on this?

@phaneesh707
Copy link
Contributor

@JyotinderSingh I can take this up if no one's working on it?

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh I can take this up if no one's working on it?

Assigned

@arpitbbhayani
Copy link
Contributor Author

Hello @phaneesh707,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants