Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: KeepAlive and Timeout Support #632

Open
vinitparekh17 opened this issue Sep 20, 2024 · 6 comments
Open

Feature: KeepAlive and Timeout Support #632

vinitparekh17 opened this issue Sep 20, 2024 · 6 comments
Assignees

Comments

@vinitparekh17
Copy link
Contributor

vinitparekh17 commented Sep 20, 2024

Unlike redis this is gonna be important feature for Dice

1. KeepAlive:

Why is it important?

  • To Detect dead or unresponsive connections
  • To Prevent idle connections from being closed by firewalls or NATs
  • To Reduce resource consumption on both client and server sides

How does it benefits?

  • Faster detection of disconnected clients
  • Improved reliability in unstable network environments
  • Reduced chances of "ghost" connections occupying resources

2. Timeout:

  • Client timeout
  • Command timeout
  • Connection timeout

Why is it important? / How does it benefits?

  • Prevent resource exhaustion from slow or hanging connections
  • Improve overall system responsiveness
@Dev79844
Copy link
Contributor

Hey @vinitparekh17
I would like to work on this. Can you assign it to me?

@vinitparekh17
Copy link
Contributor Author

@Dev79844 Thanks for showing your interest on this regards, One of these maintainer will assign it to you.

cc: @lucifercr07, @JyotinderSingh

@lucifercr07
Copy link
Contributor

@Dev79844 assigned, thanks for contributing.

@Dev79844
Copy link
Contributor

Hey
I have planned the implementation of keepalive and timeouts. As soon as the worker implementation is finished, I will add my code for the same.

@arpitbbhayani
Copy link
Contributor

Hello @Dev79844,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@Dev79844
Copy link
Contributor

Dev79844 commented Oct 3, 2024

Hey @arpitbbhayani
Already created a PR few days back. PR #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants