Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent {storm}: <Incorrect filepath in DOC.md for storm> #720

Closed
adityakiran1423 opened this issue Sep 25, 2024 · 6 comments · Fixed by #721
Closed

Inconsistent {storm}: <Incorrect filepath in DOC.md for storm> #720

adityakiran1423 opened this issue Sep 25, 2024 · 6 comments · Fixed by #721

Comments

@adityakiran1423
Copy link
Contributor

adityakiran1423 commented Sep 25, 2024

Steps to reproduce

Running the command go run storm/set/main.go will result in an error,. No file called main.go in storm/set folder (line 19 DOC.md)

current path in DOC.md to run storm : go run storm/set/main.go
revised path required to run storm : go run storm/set/set.go

Expected output

The expected path to run storm should be :

go run storm/set/set.go

Observed output

Running storm/set/main.go results :

go: downloading go1.23.0 (linux/amd64)
stat storm/set/main.go: no such file or directory

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. path is changed from storm/set/main.go to storm/set/set.go

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@adityakiran1423
Copy link
Contributor Author

adityakiran1423 commented Sep 25, 2024

Is it possible to assign the issue to myself?

EDIT : created branch issue-720, need authorization to push code. Getting an error if done otherwise.

@shardul08
Copy link
Contributor

created branch issue-720, need authorization to push code. Getting an error if done otherwise.

@adityakiran1423 you need to fork the repo and make changes in your copy and raise the PR to this repo. Please follow CONTRIBUTING.md for detailed instructions.

@adityakiran1423
Copy link
Contributor Author

@shardul08 , apologies for the context, I meant to say that I am not able to push to my branch (issue-720). I looked up CONTRIBUTING.md, I was going to raise a PR after I pushed to my branch, however I ran into this :

issue720

I was wondering if you could help me with this
Thanks
-Aditya

@shardul08
Copy link
Contributor

Seems like you are trying to push the branch to DiceDB repo. You will need to create a fork of DiceDB repo, create a new branch in the forked repo, make changes and push it. Once the new branch is pushed to the forked repo you will be able to raise the PR.

@adityakiran1423
Copy link
Contributor Author

adityakiran1423 commented Sep 25, 2024

Yep, totally forgot to fork the repo, apologies for the oversight
Followed the instructions are raised a PR
Link to the PR
Thanks for the help
-Aditya

@adityakiran1423
Copy link
Contributor Author

@shardul08, Hello, was wondering if there is any update on PR : #721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants