Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent MGET: Command in Dice docs isn't matching while running it via dicedb-cli #914

Open
shashi-sah2003 opened this issue Oct 2, 2024 · 3 comments
Assignees

Comments

@shashi-sah2003
Copy link

shashi-sah2003 commented Oct 2, 2024

This issue has been raised in accordance to fix issue #823

Steps to reproduce

  1. go to the dicedb-cli after running dicedb server
  2. on cli, SET key "value1"
  3. on cli, LPUSH key4 "value2"
  4. MGET key key4

Expected output (given in documentation of the command)

image

This is the output that given in the dicedb documentation

{expected_output}

Observed output

image

This is the case when keys doesn't exist previously.

NOTE: on the redis-cli and dicedb-cli it's giving the same output for the above command. one thing I have observed is that let's say key4 isn't existence then LPUSH will make a list for key4 and store its value but if keys exists then it will throw the error immediately after executing the LPUSH command. I am attaching for a case also when keys exists.

image

{observed_output}

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@surya0180
Copy link

Hi @shashi-sah2003. Is someone working on this issue? I would like work on this if no one else is assigned for this issue.

@mohdammar128
Copy link
Contributor

Hey @lucifercr07 can you assign this to me .I would like to work on it.

@JyotinderSingh
Copy link
Collaborator

Hi @shashi-sah2003. Is someone working on this issue? I would like work on this if no one else is assigned for this issue.

Assigned.

@lucifercr07 lucifercr07 changed the title Inconsistent {CMD}: <MGET command in dice/docs isn't matching while running it on dicedb-cli> Inconsistent MGET: Command in Dice docs isn't matching while running it via dicedb-cli Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants