Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider flag to disable DPoP #1266

Closed
brockallen opened this issue May 3, 2023 · 5 comments · Fixed by #1267
Closed

Consider flag to disable DPoP #1266

brockallen opened this issue May 3, 2023 · 5 comments · Fixed by #1267
Assignees
Milestone

Comments

@brockallen
Copy link
Member

brockallen commented May 3, 2023

DuendeSoftware/docs.duendesoftware.com#265 (comment)

@brockallen brockallen added this to the 6.3.0 milestone May 3, 2023
@leastprivilege
Copy link
Member

I think I would prefer to fail if a proof token is received and not the right license...

@brockallen
Copy link
Member Author

brockallen commented May 5, 2023

Something to consider -- if there is no license, should we still emit a log entry indicating that this is a licensed feature? I'm thinking the scenarios where a customer is evaluating or in dev mode and don't know it's a higher level feature.

I was thinking this would be useful for other things as well (automatic key management is the most common one that comes up).

@josephdecock
Copy link
Member

not the right license

This is distinct from no license at all? So non prod environments would be usable?

@brockallen
Copy link
Member Author

Well, that's still open for discussion. If there's no license at all I'd say it should work, but I proposed we log that you're using an Enterprise level feature so you'd know you can't just then buy Starter, for example.

@leastprivilege
Copy link
Member

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants