Claims with ClaimValueTypes.Double are not serialized as Number types

[rubo]

Which version of Duende IdentityServer are you using?
6.1.0

Which version of .NET are you using?
.NET 6

Describe the bug
Claims with ClaimValueTypes.Double serialized to JSON as String instead of Number when being added to context in the IProfileService.GetProfileDataAsync(ProfileDataRequestContext context) method.

To Reproduce
Add a Claim with value type of ClaimValueTypes.Double using context.AddRequestedClaims() method in the IProfileService.GetProfileDataAsync(ProfileDataRequestContext context) implementation.

Expected behavior
The claim value in the JSON retrieved from the userinfo endpoint must be of type Number instead of String.

I presume the problem is in ClaimsExtensions.cs and/or TokenExtensions.cs.

[leastprivilege]

Thanks for reporting. We will look into it.

[leastprivilege]

You can use ClaimValueTypes.Integer64 instead. Can you give that a try?

[leastprivilege]

Actually - the real question would be - is long.Parse() good enough for you?

I added explicit double support in this PR
DuendeSoftware/IdentityServer#911

[rubo]

@leastprivilege long.Parse() (ClaimValueTypes.Integer64) is not enough as I need to parse floating point numbers.

Regarding the PR: Why no changes in ClaimsExtensions.cs? I'm not sure where those extension methods are actually used but wouldn't it be consistent to have the same claim parsing logic everywhere?

[leastprivilege]

Good point - that might be an oversight.

The code I changed so far is def the place where you run into your problem

[leastprivilege]

tracked here:

DuendeSoftware/IdentityServer#914

[leastprivilege]

Hey,

could you try the preview to see if it works as expected?

v6.1.1-preview.1

See here to setup the dev feed:
https://docs.duendesoftware.com/identityserver/v6/overview/packaging/#dev-builds

[rubo]

@leastprivilege I don't see the v6.1.1, only a handful of v6.2.0. So I tried with the v6.2.0-alpha.0.5 and it doesn't work as expected. It still returns a string.

[leastprivilege]

I cleaned the feed. The preview is now available.

[rubo]

In v6.1.1-preview.1, it works as expected. Thank you.

[leastprivilege]

OK - thanks!