Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove the VIC-Hydro option #2597

Open
4 of 7 tasks
ekluzek opened this issue Jun 13, 2024 · 1 comment
Open
4 of 7 tasks

Deprecate and remove the VIC-Hydro option #2597

ekluzek opened this issue Jun 13, 2024 · 1 comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 13, 2024

The VIC-Hydro option was put in 12 years ago as an experimental optional hydrology method. It has NOT been used by default and is NOT tuned for the latest physics. It also requires additional fields on the surface datasets. And as such we've only supported it for two resolutions out of the box. We haven't heard about users using it as well. VIC hydrology is also not something being actively developed currently either. And as such we are planning on deprecating and removing the VIC option.

Definition of Done:

  • Remove the extra complexity in mksurfdata_esmf and it's python scripts to handle it
  • Remove building of special datasets with VIC fields on them (we should do this as part of the ctsm5.3.0 dataset update)
  • Add it to the README files as a deprecated feature along with the other deprecated features
  • Remove VIC-hydro from our testlists
  • Change the namelist option so it dies with a warning that can be overridden
  • Remove the namelist option from the code, so it's hardwired to false
  • Remove the code to handle VIC
@ekluzek ekluzek added the code health improving internal code structure to make easier to maintain (sustainability) label Jun 13, 2024
@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Jun 13, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 25, 2024

The first four items were accomplished as part of ctsm5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

No branches or pull requests

1 participant