diff --git a/README.md b/README.md index 3c2721d4..2cde122c 100644 --- a/README.md +++ b/README.md @@ -468,6 +468,9 @@ Sharing an image (only images from the internet are supported). If you pass more ``` ## 7. Share-popover on iPad + +> This no longer works since plugin version 5.5.0, see [this issue](https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052). + Carlos Sola-Llonch, a user of this plugin, pointed me at an [iOS document](https://developer.apple.com/library/ios/documentation/uikit/reference/UIActivityViewController_Class/Reference/Reference.html) stating "On iPad, you must present the view controller in a popover. On iPhone and iPod touch, you must present it modally." diff --git a/package.json b/package.json index dff1f040..dc733465 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "cordova-plugin-x-socialsharing", - "version": "5.4.7", + "version": "5.5.0", "description": "Share text, images (and other files), or a link via the native sharing widget of your device. Android is fully supported, as well as iOS 6 and up. WP8 has somewhat limited support.", "cordova": { "id": "cordova-plugin-x-socialsharing", diff --git a/plugin.xml b/plugin.xml index 788ff799..2066949d 100755 --- a/plugin.xml +++ b/plugin.xml @@ -2,7 +2,7 @@ + version="5.5.0"> SocialSharing diff --git a/src/ios/SocialSharing.m b/src/ios/SocialSharing.m index d1a9380b..600848b2 100644 --- a/src/ios/SocialSharing.m +++ b/src/ios/SocialSharing.m @@ -30,6 +30,9 @@ - (void)available:(CDVInvokedUrlCommand*)command { } - (NSString*)getIPadPopupCoordinates { + // see https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052 + return nil; + /* if (_popupCoordinates != nil) { return _popupCoordinates; } @@ -39,6 +42,7 @@ - (NSString*)getIPadPopupCoordinates { // prolly a wkwebview, ignoring for now return nil; } + */ } - (void)setIPadPopupCoordinates:(CDVInvokedUrlCommand*)command { diff --git a/www/SocialSharing.js b/www/SocialSharing.js index e336b2ae..7f534343 100644 --- a/www/SocialSharing.js +++ b/www/SocialSharing.js @@ -13,6 +13,7 @@ SocialSharing.prototype.iPadPopupCoordinates = function () { }; SocialSharing.prototype.setIPadPopupCoordinates = function (coords) { + console.log("Deprecated - setIPadPopupCoordinates no longer works since plugin version 5.5.0. See https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052"); // left,top,width,height cordova.exec(function() {}, this._getErrorCallback(function() {}, "setIPadPopupCoordinates"), "SocialSharing", "setIPadPopupCoordinates", [coords]); };