From 64587459f708914dd1088c794de39edf69a7e15e Mon Sep 17 00:00:00 2001 From: Christopher Costa Date: Mon, 13 Feb 2017 17:10:52 -0800 Subject: [PATCH] Respond to PR feedback --- build.sh | 77 +++++++++---------- dir.traversal.targets | 2 - .../Microsoft.NETCore.ILAsm.builds | 4 +- .../Microsoft.NETCore.ILAsm.pkgproj | 4 +- .../Microsoft.NETCore.ILDAsm.builds | 4 +- .../Microsoft.NETCore.ILDAsm.pkgproj | 4 +- .../Microsoft.NETCore.Jit.builds | 4 +- .../Microsoft.NETCore.Jit.pkgproj | 4 +- .../Microsoft.NETCore.Native.builds | 4 +- .../Microsoft.NETCore.Native.pkgproj | 4 +- .../Microsoft.NETCore.Runtime.CoreCLR.builds | 4 +- .../Microsoft.NETCore.Runtime.CoreCLR.pkgproj | 4 +- .../Microsoft.NETCore.TestHost.builds | 4 +- .../Microsoft.NETCore.TestHost.pkgproj | 5 +- ...soft.TargetingPack.Private.CoreCLR.pkgproj | 4 +- src/.nuget/{packaging.props => dir.props} | 11 ++- src/.nuget/{packaging.targets => dir.targets} | 2 +- src/.nuget/packages.builds | 2 +- 18 files changed, 71 insertions(+), 76 deletions(-) rename src/.nuget/{packaging.props => dir.props} (97%) rename src/.nuget/{packaging.targets => dir.targets} (91%) diff --git a/build.sh b/build.sh index e42d9ac791d8..a312f469a6cb 100755 --- a/build.sh +++ b/build.sh @@ -304,46 +304,43 @@ isMSBuildOnNETCoreSupported() if [ "$__HostArch" == "x64" ]; then if [ "$__HostOS" == "Linux" ]; then - if [ "$__msbuildonunsupportedplatform" == "1" ]; then - __isMSBuildOnNETCoreSupported=1 - else - case "$__HostDistroRid" in - "centos.7-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "debian.8-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "fedora.23-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "fedora.24-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "opensuse.13.2-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "opensuse.42.1-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "rhel.7"*"-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "ubuntu.14.04-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "ubuntu.16.04-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "ubuntu.16.10-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - "alpine.3.4.3-x64") - __isMSBuildOnNETCoreSupported=1 - ;; - *) - esac - fi + case "$__HostDistroRid" in + "centos.7-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "debian.8-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "fedora.23-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "fedora.24-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "opensuse.13.2-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "opensuse.42.1-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "rhel.7"*"-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "ubuntu.14.04-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "ubuntu.16.04-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "ubuntu.16.10-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + "alpine.3.4.3-x64") + __isMSBuildOnNETCoreSupported=1 + ;; + *) + __isMSBuildOnNETCoreSupported=$__msbuildonunsupportedplatform + esac elif [ "$__HostOS" == "OSX" ]; then __isMSBuildOnNETCoreSupported=1 fi diff --git a/dir.traversal.targets b/dir.traversal.targets index c0b284d79130..96ad070bb4a6 100644 --- a/dir.traversal.targets +++ b/dir.traversal.targets @@ -17,6 +17,4 @@ - - \ No newline at end of file diff --git a/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds b/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds index cbb2048eb73f..c0e29c0573cc 100644 --- a/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds +++ b/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds @@ -1,11 +1,11 @@ - + - + diff --git a/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj b/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj index 57eb030489c0..bfa4bd833d26 100644 --- a/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj +++ b/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj @@ -1,6 +1,6 @@  - + x64;x86;arm64;arm; @@ -16,5 +16,5 @@ - + diff --git a/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds b/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds index 3c8ff0810c5c..95f043d2cb1d 100644 --- a/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds +++ b/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds @@ -1,11 +1,11 @@ - + - + \ No newline at end of file diff --git a/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj b/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj index 07a9483958fc..4236e316ecca 100644 --- a/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj +++ b/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj @@ -1,6 +1,6 @@  - + x64;x86;arm64;arm; @@ -15,5 +15,5 @@ - + diff --git a/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds b/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds index 372d8d8d641c..3b7bc1ccd41f 100644 --- a/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds +++ b/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds @@ -1,11 +1,11 @@ - + - + \ No newline at end of file diff --git a/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj b/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj index 71a4d7bc7822..5ed709e2b3ed 100644 --- a/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj +++ b/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj @@ -1,6 +1,6 @@  - + x64;x86;arm64;arm; @@ -18,5 +18,5 @@ - + diff --git a/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.builds b/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.builds index 976f64b1bf68..6b0e756f2102 100644 --- a/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.builds +++ b/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.builds @@ -2,12 +2,12 @@ - + - + \ No newline at end of file diff --git a/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.pkgproj b/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.pkgproj index 12e6ca1c92b2..ddaa191622cf 100644 --- a/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.pkgproj +++ b/src/.nuget/Microsoft.NETCore.Native/Microsoft.NETCore.Native.pkgproj @@ -3,7 +3,7 @@ - + x64;x86;arm64;arm; @@ -12,5 +12,5 @@ - + diff --git a/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds b/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds index 372d8d8d641c..3b7bc1ccd41f 100644 --- a/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds +++ b/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds @@ -1,11 +1,11 @@ - + - + \ No newline at end of file diff --git a/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj b/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj index c0328356b54c..bf3177bef64b 100644 --- a/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj +++ b/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj @@ -1,6 +1,6 @@  - + x64;x86;arm64;arm; @@ -15,5 +15,5 @@ - + diff --git a/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds b/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds index 93d9e296d479..79cfecbf2db1 100644 --- a/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds +++ b/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds @@ -1,11 +1,11 @@ - + - + diff --git a/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj b/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj index a1684ca45c58..991d7621c24e 100644 --- a/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj +++ b/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj @@ -1,6 +1,6 @@  - + x64;x86;arm64;arm; @@ -9,4 +9,5 @@ - + + diff --git a/src/.nuget/Microsoft.TargetingPack.Private.CoreCLR/Microsoft.TargetingPack.Private.CoreCLR.pkgproj b/src/.nuget/Microsoft.TargetingPack.Private.CoreCLR/Microsoft.TargetingPack.Private.CoreCLR.pkgproj index 253cba083d10..0d4fb18ea029 100644 --- a/src/.nuget/Microsoft.TargetingPack.Private.CoreCLR/Microsoft.TargetingPack.Private.CoreCLR.pkgproj +++ b/src/.nuget/Microsoft.TargetingPack.Private.CoreCLR/Microsoft.TargetingPack.Private.CoreCLR.pkgproj @@ -1,6 +1,6 @@  - + true true @@ -15,5 +15,5 @@ lib/netstandard1.0 - + \ No newline at end of file diff --git a/src/.nuget/packaging.props b/src/.nuget/dir.props similarity index 97% rename from src/.nuget/packaging.props rename to src/.nuget/dir.props index f1daa2629bb2..fc46b2eca08d 100644 --- a/src/.nuget/packaging.props +++ b/src/.nuget/dir.props @@ -1,6 +1,6 @@ - + @@ -8,17 +8,16 @@ <_archRidIndex>$([MSBuild]::Add($(_distroRidIndex), 1)) $(__DistroRid.SubString(0, $(_distroRidIndex))) win10 + $(__DistroRid.SubString($(_archRidIndex))) - - + $(Platform) + $(BuildArch) + $(OSRid) Windows_NT;OSX;Linux ;$(SupportedPackageOSGroups); - $(Platform) - $(BuildArch) - <_runtimeOSVersionIndex>$(RuntimeOS.IndexOfAny(".-0123456789")) <_runtimeOSFamily Condition="'$(_runtimeOSVersionIndex)' != '-1'">$(RuntimeOS.SubString(0, $(_runtimeOSVersionIndex))) <_isSupportedOSGroup>true diff --git a/src/.nuget/packaging.targets b/src/.nuget/dir.targets similarity index 91% rename from src/.nuget/packaging.targets rename to src/.nuget/dir.targets index 8439616d8286..3d310b015203 100644 --- a/src/.nuget/packaging.targets +++ b/src/.nuget/dir.targets @@ -6,7 +6,7 @@ - + <_projectsToBuild Include="@(Project)" Condition="'%(Project.PackageTargetRuntime)' == '$(PackageRID)' OR '%(Project.PackageTargetRuntime)' == ''" /> diff --git a/src/.nuget/packages.builds b/src/.nuget/packages.builds index 945e3608ae39..719799a77889 100644 --- a/src/.nuget/packages.builds +++ b/src/.nuget/packages.builds @@ -1,5 +1,5 @@ - +