Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Releaseable trait again #14

Closed
tgolsson opened this issue Aug 14, 2019 · 0 comments
Closed

Remove Releaseable trait again #14

tgolsson opened this issue Aug 14, 2019 · 0 comments
Labels
a: high-level-api Pertaining to the higher level Wrappers bug Something isn't working

Comments

@tgolsson
Copy link
Member

Describe the bug

The Releaseable trait does not work as it's supposed to w.r.t. inheritance and callbacks, which leads to fully correct code, but not necessarily expected behaviors.

Me and @MaikKlein removed the trait to prevent this from causing issues until we find a better solution, in issue #7 and PR #8 (commit 4902bc5). However, it was accidentally diffed the wrong way and added back here when comparing the internal project with this repository, in commit 0f30263.

@tgolsson tgolsson added bug Something isn't working a: high-level-api Pertaining to the higher level Wrappers labels Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: high-level-api Pertaining to the higher level Wrappers bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant