Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ncollide3d usage #17

Closed
repi opened this issue Sep 10, 2019 · 4 comments
Closed

Remove ncollide3d usage #17

repi opened this issue Sep 10, 2019 · 4 comments
Assignees
Labels
a: high-level-api Pertaining to the higher level Wrappers help wanted Extra attention is needed

Comments

@repi
Copy link
Contributor

repi commented Sep 10, 2019

Currently the physx crate uses ncollide3d for a couple of things, we should try and remove that usage as it feels unnecessary to bring in a different collision system in addition to physx.

@repi repi added help wanted Extra attention is needed a: high-level-api Pertaining to the higher level Wrappers labels Sep 10, 2019
@repi
Copy link
Contributor Author

repi commented Sep 14, 2019

It is only this function that uses it in heightfield.rs so should be pretty easy to remove.

    /// Build the heightfield into a PhysX geometry and a trimesh we can use for rendering.
    pub fn build_with_trimesh(&self, cooking: &mut Cooking) -> (Geometry, TriMesh<f32>) {
        let heights = self.generate_heights();
        let heightfield_desc = self.create_desc(&heights);

        let vertices = self.generate_vertices(&heights);
        (
            cooking.create_heightfield(heightfield_desc, true),
            quad_with_vertices(&vertices[..], self.size.0, self.size.1),
        )
    }

@MaikKlein MaikKlein self-assigned this Sep 23, 2019
@MaikKlein
Copy link
Member

I talked to @tgolsson and this function is not used atm. Either we remove it or we triangulate it ourselves.

I'll nuke ncollide/nalgebra from the repo now.

@repi
Copy link
Contributor Author

repi commented Sep 23, 2019

Sweet!

#22 is the issue of converting nalgebra to glam

@repi
Copy link
Contributor Author

repi commented Oct 13, 2019

Fixed in #25

@repi repi closed this as completed Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: high-level-api Pertaining to the higher level Wrappers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants