Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables in build.rs #78

Closed
wants to merge 1 commit into from

Conversation

Jasper-Bekkers
Copy link
Contributor

@Jasper-Bekkers Jasper-Bekkers commented Jul 7, 2020

The paths generated for the build tool were too long on windows. Work around it by using env vars.

Fix #75

@Jasper-Bekkers Jasper-Bekkers marked this pull request as draft July 7, 2020 09:57
@repi
Copy link
Contributor

repi commented Jul 7, 2020

Ah failing on Linux, guess %PHYSX_ROOT% should be $PHYSX_ROOT on non-Windows?

@Jake-Shadle
Copy link
Member

It should just ignore doing that on non-Windows hosts, none of the others have that dumb limitation.

@repi
Copy link
Contributor

repi commented Jul 7, 2020

That's also true :)

@VZout
Copy link
Member

VZout commented Jul 10, 2020

Small update on this draft; Turns out it doesn't work for windows anymore 🤷‍♂️

@mergify mergify bot deleted the env-vars-in-build-rs branch June 30, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android cross-compiling from Windows error "cargo:warning=The command line is too long"
4 participants