Initial aarch64-apple-darwin support #123
Conversation
|
I'm not actually sure what would be different between archs here. It's just a bunch of structs with repr(C), and all the platforms we support are 64-bit and, I think, pretty much entirely layout structs the same way? Do we really need platform specific structgen.rs ? |
|
Yeah I'm not fully sure either, I've done it this way before also of just copying it over from other platforms, @h3r2tic do you know more specifically where compiler/arch differences could affect the structgen within 64-bit? |
|
@h3r2tic what do you think of the risks of just getting this in vs generating a proper definition? Seems to be working well, been using it for a couple of months and no seen physx issues |
|
I spent a couple of evenings trying to replace the bindgen stuff with an easier to maintain Python version but the clang-bindings lacked some things, so getting a 1-1 match in output wasn't possible. It might be more worthwhile trying to use the libclang Rust bindings to generate it. |
|
Added an issue here: #127, if we want to tackle it. |
In reality: who knows! If we reuse x64 struct definitions for arm64, we are crossing fingers and relying on C++ ABI compatibility between those (we rely on repr(C) between C and Rust, but the generated struct layout matches the C++ ABI). In theory we shouldn't be relying on pre-generated struct layouts at all, although they are de-facto stable. So we should run structgen on aarch64-apple-darwin, but the build process has changed for clang/libtooling, and I'm at a loss trying to get it to work. I'd much rather go with @tgolsson's idea of relying on the devs of Python's or Rust's bindings, and using a sane build system. Seeing as that's not something we have right now, and considering you've been testing aarch64-apple-darwin for a while, we could just merge this, and at some point replace the generator with one written in not-C++. |
Adds initial support for Mac M1 ARM CPUs.
This may not be correct as had problems running our pxbind structgen utility on Mac M1 so for now just copy'n'pasted the x86_64 Mac structgen files. Does seem to run but could be subtle differences (that could cause catastrophic failures)?
Resolves: #92