Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components need a way of reporting the dimensions of their UI obscuring a map or scene view #299

Open
dfeinzimer opened this issue Apr 11, 2023 · 1 comment
Labels
Effort - medium A medium level of effort to complete enhancement New feature or request

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Apr 11, 2023

Certain components such as search, the un trace tool, floor filter stay on screen for an extended period and can end up covering significant portions of the screen. We need to identify a common pattern for components to report the size of their UI so that the .contentInsets() modifier can be usefully applied to a map or scene view.

Original report in Swift 3931:

The geo code result is off center and tucked behind they search widget. Probably a keyboard offer thing?

Screenshot 2023-04-11 at 09 44 13

Components that can benefit from this:

Component Evaluation
Authenticator Not persistently on screen
BasemapGallery Not persistently on screen
Bookmarks Not persistently on screen
Compass Too small
FloatingPanel ?
FloorFilter
OverviewMap
Popup ?
Scalebar Too small
Search
UtilityNetworkTrace

safeAreaInset(edge:alignment:spacing:content:) seems to Apple's native solution to this. A quick test with the floor filter component is promising but there're some issues with the attribution bar

@dfeinzimer dfeinzimer added the bug Something isn't working label Apr 11, 2023
@dfeinzimer dfeinzimer added enhancement New feature or request Effort - large A high level of effort to complete and removed bug Something isn't working labels Apr 11, 2023
@dfeinzimer dfeinzimer changed the title [Search] Search result pin can become obscured Components need a way of reporting the dimensions of their UI obscuring a map or scene view Apr 11, 2023
@dfeinzimer dfeinzimer added Effort - medium A medium level of effort to complete and removed Effort - large A high level of effort to complete labels Apr 11, 2023
@mhdostal
Copy link
Member

Related: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort - medium A medium level of effort to complete enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants