Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use confirmationDialog instead of alert #348

Open
rolson opened this issue Jun 8, 2023 · 2 comments
Open

Use confirmationDialog instead of alert #348

rolson opened this issue Jun 8, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rolson
Copy link
Contributor

rolson commented Jun 8, 2023

We should look at using the new .confirmationDialog modifier for presenting alerts. This is available in iOS 17 and macOS Sonoma I believe.

image
@rolson rolson added the enhancement New feature or request label Jun 8, 2023
@philium
Copy link
Contributor

philium commented Jun 8, 2023

Those modifiers were actually introduced in iOS 15. The toolkit already uses one of them in UtilityNetworkTrace.

@yo1995 yo1995 mentioned this issue Jun 9, 2023
Merged
@yo1995
Copy link
Contributor

yo1995 commented Jun 13, 2023

confirmationDialog was first designed as the replacement of iOS UIAlertController's actionSheet style. It seems like this improvement is focused on bringing macOS UI more unified with mobile platforms. Currently on Mac Catalyst they don't look native for desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philium @rolson @yo1995