[Tests bug] Incorrect calls to skipAnimations(page);
#10326
Labels
0 - new
New issues that need assignment.
needs milestone
Planning workflow - pending milestone assignment, has priority and/or estimate.
p - low
Issue is non core or affecting less that 10% of people using the library
testing
Issues related to automated or manual testing.
Priority impact
p - low
Test type
End to end tests
Which Component(s)
All
Unstable Tests
In many places in Calcite E2E tests,
await skipAnimations(page);
is called beforepage.setContent()
:calcite-design-system/packages/calcite-components/src/components/alert/alert.e2e.ts
Lines 122 to 123 in e9d1862
skipAnimations()
is adding a<style>
tag to the page.The issue is that
page.setContent()
clears all other content from the page, thus the<style>
tag added byskipAnimations()
is removed.Please review all the places where
skipAnimations()
is called in such way to check ifskipAnimations()
is necessary at all (since tests are supposevely working without it?). If it is necessary, then move the call to be afterpage.setContent()
.Test error, if applicable
No response
PR skipped, if applicable
No response
Additional Info
For reference, see the implementation of
page.setContent()
:https://github.com/ionic-team/stencil/blob/814642f9035df24b1ed45019991542a3fba0884b/src/testing/puppeteer/puppeteer-page.ts#L208
The text was updated successfully, but these errors were encountered: