Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GPU segfault introduced in #1219 #1251

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix GPU segfault introduced in #1219 #1251

merged 4 commits into from
Sep 17, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Sep 17, 2024 •
edited
Loading

Summary

Fix segfault on GPU for abl_meso_input_*pa

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Closes #1250

@marchdf marchdf marked this pull request as ready for review September 17, 2024 21:34
@marchdf marchdf enabled auto-merge (squash) September 17, 2024 21:35
moprak-nrel
moprak-nrel reviewed Sep 17, 2024
View reviewed changes
amr-wind/equation_systems/temperature/source_terms/ABLMesoForcingTemp.cpp
for (int i = 0; i < m_nht; i++) {
const amrex::Real height_interpolated_theta = amr_wind::interp::linear(
m_meso_ht, time_interpolated_theta, tavg.line_centroids()[i]);
meso_ht, time_interpolated_theta, tavg.line_centroids()[i]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a tavg_lc similar to change for velocity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is mostly a no-op. I just did that for vel because it was happening twice...

@marchdf marchdf merged commit eca66d4 into Exawind:main Sep 17, 2024
15 checks passed
@marchdf marchdf deleted the fix-gpu-meso branch September 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moprak-nrel moprak-nrel moprak-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault on GPU in abl_meso_input_*pa
2 participants
@marchdf @moprak-nrel