Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend vinsert unit tests to ensure correct behaviour with "bad" masks #3753

Open
Sonicadvance1 opened this issue Jun 24, 2024 · 0 comments
Open

Extend vinsert unit tests to ensure correct behaviour with "bad" masks #3753

Sonicadvance1 opened this issue Jun 24, 2024 · 0 comments

Comments

@Sonicadvance1
Copy link
Member

Current vinsert{i128,f128} tests only test for literal 0 or 1, we should have tests with the high bits set to ensure correct behaviour.
Almost had a behaviour change in a PR that woudn't have been caught.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sonicadvance1