Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] This line should be updated for gymnasium 1.0.0 #176

Open
jamartinh opened this issue Dec 8, 2023 · 2 comments
Open

[Fix] This line should be updated for gymnasium 1.0.0 #176

jamartinh opened this issue Dec 8, 2023 · 2 comments

Comments

@jamartinh
Copy link

The line:

Minari/minari/utils.py

Line 15 in e24113b

from gymnasium.wrappers.record_episode_statistics import RecordEpisodeStatistics

This currently causes an import error in gymnasium 1.0.0rc

Should be changed to:

from gymnasium.wrappers import RecordEpisodeStatistics
@younik
Copy link
Member

younik commented Dec 8, 2023

Hello @jamartinh, make sense!

Do you want to open a PR fixing this? Thank you.

@jamartinh jamartinh mentioned this issue Dec 8, 2023
Open
@jamartinh
Copy link
Author

PR done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamartinh @younik