Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app version of example app (ostracon #533) #16

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 2 comments
Open
Tracked by #1

Fix app version of example app (ostracon #533) #16

0Tech opened this issue Nov 1, 2023 · 2 comments

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@0Tech 0Tech assigned Mdaiki0730 and loloicci and unassigned Mdaiki0730 Nov 2, 2023
@loloicci loloicci changed the title Triage on ostracon#533 Fix app version of example app#533 Dec 6, 2023
@loloicci loloicci changed the title Fix app version of example app#533 Fix app version of example app (ostracon #533) Dec 6, 2023
@loloicci
Copy link

loloicci commented Dec 18, 2023

This includes 2 issues/fixes.

  1. The example app's version is not good / fix it
  2. Problem with the upgrade function if it upgrades app version

Though 1's fix is once pushed to tendermint upstream, it is not merged. (tendermint/tendermint#8151). So we will not fix it. It is not a problem if we set the app version in finschia correctly.

2 is under research.

@loloicci
Copy link

Problem with the upgrade function if it upgrades app version

It depends on the app's proxyApp.Query().InfoSync(proxy.RequestInfo) 's implementation. Especially, if the client is at the genesis block, there is a known problem that this information is sometimes wrong. tendermint/tendermint#8151 contains the fix for it. Other than that, there is no problem if the client implements it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants