Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split marshaled genesis before saving it to the DB #18

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 1 comment
Open
Tracked by #1

Split marshaled genesis before saving it to the DB #18

0Tech opened this issue Nov 1, 2023 · 1 comment
Assignees
@0Tech
Labels
A: improvement Changes in existing functionality Breaking Change priority/major

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023 •
edited
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Nov 1, 2023
Open
50 tasks
@0Tech 0Tech self-assigned this Nov 2, 2023
@0Tech
Copy link
Author

0Tech commented Nov 3, 2023

By this patch, cometbft will split marshaled genesis before save it to the DB. In case of upstreaming this patch, we need to fix a bug and refactor the logic.

Pros:

  • cometbft will be able to handle a big genesis file.

Cons:

  • It's DB breaking change.

@0Tech 0Tech changed the title Triage on ostracon#576 Split marshaled genesis before saving it to the DB Nov 3, 2023
@0Tech 0Tech added Breaking Change A: improvement Changes in existing functionality labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0Tech 0Tech

Labels
A: improvement Changes in existing functionality Breaking Change priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0Tech