Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive extra prometheus metrics for performance testing #53

Open
tkxkd0159 opened this issue Nov 16, 2023 · 0 comments
Open

Revive extra prometheus metrics for performance testing #53

tkxkd0159 opened this issue Nov 16, 2023 · 0 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@tkxkd0159
Copy link
Member

tkxkd0159 commented Nov 16, 2023

Descriptions

We added some prometheus metrics to do performance test. So we revert now to sync with upstream, but we can apply them again when we need. This issue was created to track such history.

ref. #46, #49, #50

Target metrics

  • BlockExecutionTime : gauge value for measuring execBlockOnProxyApp<BeginBlock, DeliverTx, EndBlock> processing time => cometbft log this as histogram value
  • BlockCommitTime : gauge value for measuring blockExec.Commit processing time
    -> FlushMempool + CommitSync + UpdateMempool
  • BlockAppCommitTime : gauge value for measuring proxyApp.CommitSync() processing time
  • BlockUpdateMempoolTime : gauge value for measuring mempool.Update processing time
  • RecheckTime : gauge value for measuring mempool.Recheck processing titme
    This is not core feature. So it depends on personal preference. We need to suggest it to upstream if we really need to aggregate this metrics.
  • Proposal, Prevote, Precommit, CommitExecuting, CommitCommitting, CommitRechecking, WaitingForNewRound : Cometbft logs those values as a histogram, while Ostracon additionally logs them as a gauge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

1 participant