Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.10 #19

Closed
rlidwka opened this issue Mar 17, 2023 · 3 comments
Closed

Update to bevy 0.10 #19

rlidwka opened this issue Mar 17, 2023 · 3 comments

Comments

@rlidwka
Copy link

rlidwka commented Mar 17, 2023

bevy_flycam dev dependency is not updated yet

I've tried to update, see this commit: rlidwka@48d1b7c

EntityRenderCommand is merged into RenderCommand (biggest change here), stages are replaced with system sets, and so on

It compiles, but returns real-time errors which I don't know how to debug. Can anyone help?

@PikminGuts92
Copy link
Contributor

I'm in the same situation. I was able to get it compiling and the example running. However, the infinite grid does not display and there's runtime errors. This is the branch I made. Looks like we made similar changes. https://github.com/PikminGuts92/bevy_infinite_grid/tree/bevy-0.10

My error seems to be shader related. I suspect it might be my RenderCommand implementations as migrating from EntityRenderCommand was unclear to me. bevyengine/bevy#6885

simple_example

2023-03-21T00:20:56.236287Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: expected expression, found '#'
   ┌─ wgsl:57:41
   │
57 │     cascades: array<DirectionalCascade, #{MAX_CASCADES_PER_LIGHT}>,
   │                                         ^ expected expression


2023-03-21T00:20:56.242526Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: redefinition of `derivative`
    ┌─ wgsl:107:9
    │
107 │     let derivative = fwidth(coord);
    │         ^^^^^^^^^^ previous definition of `derivative`
    ·
114 │     let derivative = fwidth(coord * 0.1);
    │         ^^^^^^^^^^ redefinition of `derivative`


2023-03-21T00:20:56.355695Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: redefinition of `derivative`
    ┌─ wgsl:107:9
    │
107 │     let derivative = fwidth(coord);
    │         ^^^^^^^^^^ previous definition of `derivative`
    ·
114 │     let derivative = fwidth(coord * 0.1);
    │         ^^^^^^^^^^ redefinition of `derivative`

@PikminGuts92
Copy link
Contributor

PikminGuts92 commented Mar 21, 2023

I made some changes to the queries in my RenderCommand implementations, added missing values for bevy provided shaders, and fixed duplicate variable definition in plane shader. The example is now rendering correctly without anymore console errors.

PR available: #20

simple_9faMG7fpYD

@PikminGuts92
Copy link
Contributor

PikminGuts92 commented May 4, 2023

@rlidwka looks like my PR was merged in yesterday. There's also a new release on crates.io so presumably the changes are in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants