Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ioutil should be removed in favour of io and/or os. #55

Closed
Foxboron opened this issue Apr 14, 2021 · 2 comments · Fixed by #66
Closed

ioutil should be removed in favour of io and/or os. #55

Foxboron opened this issue Apr 14, 2021 · 2 comments · Fixed by #66
Labels
good first issue Good for newcomers

Comments

@Foxboron
Copy link
Owner 

λ sbctl master» egrep -nrH "io/ioutil" .          
./database.go:5:	"io/ioutil"
./keys.go:11:	"io/ioutil"
./util.go:8:	"io/ioutil"
./sbctl.go:7:	"io/ioutil"
./bundles.go:6:	"io/ioutil"

Should be fairly easy I believe so a good first issue :)

https://golang.org/doc/go1.16#ioutil
@Foxboron Foxboron added the good first issue Good for newcomers label Apr 14, 2021
@ericonr
Copy link
Contributor

ericonr commented Apr 14, 2021

This will break compatibility with Go <1.16, right? Might matter for Debian (or other stable distro) users .

@Foxboron
Copy link
Owner Author

Debian is packaging 1.16 before they are packaging sbctl :) That is a bet I'm willing to take. 1.16 is also in Unstable so not that far off.

@igo95862 igo95862 mentioned this issue May 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ioutil igo95862/sbctl
2 participants
@Foxboron @ericonr