Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Online leak (fixed with beta 16) #55

Closed
DursunCanPoyraz opened this issue Dec 29, 2020 · 5 comments
Closed

Latest Online leak (fixed with beta 16) #55

DursunCanPoyraz opened this issue Dec 29, 2020 · 5 comments
Labels

Comments

@DursunCanPoyraz
Copy link

When the user is blocked from appearing online, they should not appear in the user list in the last online order.

@clarkwinkelmann
Copy link
Member

clarkwinkelmann commented Jan 2, 2021

Thanks for the report. This is indeed a serious issue.

The problem actually lies with Flarum itself. The sorting ability isn't implemented by User Directory. Anyone with "View user list" permission can exploit the leak from Flarum API.

I have created an issue with details on the Flarum tracker flarum/framework#2519

I will keep this issue open for now since other people might notice the problem and come look on this repository.

@clarkwinkelmann clarkwinkelmann changed the title Latest Online Latest Online leak Jan 2, 2021
@clarkwinkelmann
Copy link
Member

The issue should be fixed in Flarum beta 16 once we merge flarum/framework#2634

We will need to remove the sort option in FoF User Directory to prevent people from getting a 400 error once the sort field no longer exists.

Since the sort field will still be available to some users, we could dynamically continue to show the sort option to users with user.viewLastSeenAt permission.

@davwheat
Copy link
Member

davwheat commented Mar 5, 2021

Now merged into core. When beta 16 releases, this will be fixed (once you upgrade your forum, of course).

For the meantime, you could fork this ext and remove the sorting option, or fork core and patch core with this PR, or just wait it out.

@davwheat davwheat closed this as completed Mar 5, 2021
@davwheat
Copy link
Member

davwheat commented Mar 5, 2021

Reopened to keep the issue visible until beta 16 releases.

@davwheat davwheat reopened this Mar 5, 2021
@davwheat davwheat changed the title Latest Online leak Latest Online leak (fixed with beta 16) Mar 5, 2021
@imorland
Copy link
Member

Resolved 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants