Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing results #2

Closed
pmorerio opened this issue Nov 22, 2016 · 1 comment
Closed

Reproducing results #2

pmorerio opened this issue Nov 22, 2016 · 1 comment

Comments

@pmorerio
Copy link

Hi,
first of all thanks for sharing your code. I was trying to reproduce the results presented in the paper for the Amazon experiment, but I realized that when setting lambda=0.0 and/or adversarial_representation=False the numerical results for the risk do not change at all.

adversarial_representation=True
image

adversarial_representation=False
image

@pgermain
Copy link
Contributor

Thanks @pmorerio for raising this. With some combinations of datasets/parameters, the adversarial component has more or less influence on the final result. Note also that the experiment results on the paper are not necessarily obtained with the same parameters (but chosen by the reverse validation procedure) for DANN and standard NN.

I changed the default example parameters to present a case where the adversarial component is more effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants