Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Fishing doesn't catch the fishing bobber reliably #316

Closed
Bloo-dev opened this issue Oct 28, 2019 · 5 comments · Fixed by #317
Closed

End Fishing doesn't catch the fishing bobber reliably #316

Bloo-dev opened this issue Oct 28, 2019 · 5 comments · Fixed by #317
Labels
bug Something isn't working

Comments

@Bloo-dev
Copy link
Member

Since the latest update to end fishing the module doesn't catch the bobber reliably - at least on the public server which is running the latest copy.

Expected Behavior

When a rod is cast the bobber should be caught almost every time (at least 90% of the time).

Current Behavior

The bobber drops to the void every time.

Workaround

Right now, casting the bobber against a wall fixes the issue.

Environment

Tested and observed on Public Server 5

@BluePsychoRanger do you have an idea why this would be happening? This is after the small armor stand change.

@Bloo-dev Bloo-dev added bug Something isn't working needs investigation labels Oct 28, 2019
@BluePsychoRanger
Copy link
Member

The small armor stand has a smaller hit box, so the speed of the bobber may be too fast to hook onto the small armor stand. Possible fix may be to use a normal size armor stand or summon the armor stand further in front of the bobber. I’ll try to fix the bug when I have time.

@Bloo-dev
Copy link
Member Author

The switch the a small armor stand was made to align the bobber's position once hooked on with the tripwire trigger radius. Are we sure this is still an issue or can we simply revert that change?

@BluePsychoRanger
Copy link
Member

Alright, I fixed the issue with normal rod casting, but now I have an issue where hitting a wall is unreliable. I'll try to fix it later, when I have more time. ATM, I have a version which hooks on in the void almost every time, except when the bobber goes too far down. Best results come from looking up/striaght forward and casting the rod.

@BluePsychoRanger
Copy link
Member

BluePsychoRanger commented Oct 30, 2019

Alright, I've tested it, and got it to work eventually. An AFK farm is still possible, but it's much more reliable when not hitting a wall now, and less reliable when hitting a wall.
#317

@Bloo-dev
Copy link
Member Author

That sounds reasonable to me, you're meant to fish in the void, not in a wall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants